netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrei Vagin <avagin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Christian Brauner <christian.brauner@ubuntu.com>,
	Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
Subject: Re: [PATCH net-next v4] net: Allow to specify ifindex when device is moved to another namespace
Date: Tue, 6 Apr 2021 11:31:40 -0700	[thread overview]
Message-ID: <20210406113140.467a0cb2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210406075448.203816-1-avagin@gmail.com>

On Tue,  6 Apr 2021 00:54:48 -0700 Andrei Vagin wrote:
> v3: check that new_ifindex is positive.
> v4: - use ifla_policy to validate IFLA_NEW_IFINDEX.
>     - don't change the prototype of dev_change_net_namespace that is
>       used in many places.

I'm afraid v3 got merged before I sent my review, would you mind
rebasing on net-next and resending an incremental change?

  reply	other threads:[~2021-04-06 18:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  7:54 [PATCH net-next v4] net: Allow to specify ifindex when device is moved to another namespace Andrei Vagin
2021-04-06 18:31 ` Jakub Kicinski [this message]
2021-04-08 13:02 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210406113140.467a0cb2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=alexander.mikhalitsyn@virtuozzo.com \
    --cc=avagin@gmail.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).