From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB28C43460 for ; Wed, 7 Apr 2021 22:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE2A661164 for ; Wed, 7 Apr 2021 22:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229690AbhDGWN0 (ORCPT ); Wed, 7 Apr 2021 18:13:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43636 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhDGWNZ (ORCPT ); Wed, 7 Apr 2021 18:13:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 4B5D84266DBD3; Wed, 7 Apr 2021 15:13:15 -0700 (PDT) Date: Wed, 07 Apr 2021 15:13:10 -0700 (PDT) Message-Id: <20210407.151310.197667379826410564.davem@davemloft.net> To: colin.king@canonical.com Cc: aelior@marvell.com, skalluru@marvell.com, GR-everest-linux-l2@marvell.com, kuba@kernel.org, eilong@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bnx2x: Fix potential infinite loop From: David Miller In-Reply-To: <20210407142802.495539-1-colin.king@canonical.com> References: <20210407142802.495539-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Wed, 07 Apr 2021 15:13:15 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Colin King Date: Wed, 7 Apr 2021 15:28:02 +0100 > From: Colin Ian King > > The for_each_tx_queue loop iterates with a u8 loop counter i and > compares this with the loop upper limit of bp->num_queues that > is an int type. There is a potential infinite loop if bp->num_queues > is larger than the u8 loop counter. Fix this by making the loop > counter the same type as bp->num_queues. > > Addresses-Coverity: ("Infinite loop") > Fixes: ad5afc89365e ("bnx2x: Separate VF and PF logic") > Signed-off-by: Colin Ian King Please show how num_queues can take on a value larger than 255. Thank you.