From: Jakub Kicinski <kuba@kernel.org>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Richard Cochran <richardcochran@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [net-next, v2, 2/2] enetc: support PTP Sync packet one-step timestamping
Date: Thu, 8 Apr 2021 09:07:08 -0700 [thread overview]
Message-ID: <20210408090708.7dc9960f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210408090250.21dee5c6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, 8 Apr 2021 09:02:50 -0700 Jakub Kicinski wrote:
> if (priv->flags & ONESTEP_BUSY) {
> skb_queue_tail(&priv->tx_skbs, skb);
> return ...;
> }
> priv->flags |= ONESTEP_BUSY;
Ah, if you have multiple queues this needs to be under a separate
spinlock, 'cause netif_tx_lock() won't be enough.
next prev parent reply other threads:[~2021-04-08 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:13 [net-next, v2, 0/2] enetc: support PTP Sync packet one-step timestamping Yangbo Lu
2021-04-08 11:13 ` [net-next, v2, 1/2] enetc: mark TX timestamp type per skb Yangbo Lu
2021-04-08 11:13 ` [net-next, v2, 2/2] enetc: support PTP Sync packet one-step timestamping Yangbo Lu
2021-04-08 16:02 ` Jakub Kicinski
2021-04-08 16:07 ` Jakub Kicinski [this message]
2021-04-09 6:37 ` Claudiu Manoil
2021-04-09 16:09 ` Jakub Kicinski
2021-04-09 19:32 ` Claudiu Manoil
2021-04-09 19:44 ` Jakub Kicinski
2021-04-12 9:15 ` Y.b. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408090708.7dc9960f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).