From: Rob Herring <robh@kernel.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Arend van Spriel" <aspriel@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-hsien Lin" <chi-hsien.lin@infineon.com>,
"Wright Feng" <wright.feng@infineon.com>,
"Chung-hsien Hsu" <chung-hsien.hsu@infineon.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map
Date: Fri, 9 Apr 2021 13:46:06 -0500 [thread overview]
Message-ID: <20210409184606.GA3937918@robh.at.kernel.org> (raw)
In-Reply-To: <20210408113022.18180-2-shawn.guo@linaro.org>
On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote:
> Add optional brcm,ccode-map property to support translation from ISO3166
> country code to brcmfmac firmware country code and revision.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
Can you convert this to schema first.
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
> index cffb2d6876e3..a65ac4384c04 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
> @@ -15,6 +15,12 @@ Optional properties:
> When not specified the device will use in-band SDIO interrupts.
> - interrupt-names : name of the out-of-band interrupt, which must be set
> to "host-wake".
> + - brcm,ccode-map : multiple strings for translating ISO3166 country code to
> + brcmfmac firmware country code and revision. Each string must be in
> + format "AA-BB-num" where:
> + AA is the ISO3166 country code which must be 2 characters.
> + BB is the firmware country code which must be 2 characters.
> + num is the revision number which must fit into signed integer.
Signed? So "AA-BB--num"?
You should be able to do something like:
items:
pattern: '^[A-Z][A-Z]-[A-Z][A-Z]-[0-9]+$'
>
> Example:
>
> @@ -34,5 +40,6 @@ mmc3: mmc@1c12000 {
> interrupt-parent = <&pio>;
> interrupts = <10 8>; /* PH10 / EINT10 */
> interrupt-names = "host-wake";
> + brcm,ccode-map = "JP-JP-78", "US-Q2-86";
> };
> };
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-04-09 18:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:30 [PATCH 0/2] brcmfmac: support parse country code map from DT Shawn Guo
2021-04-08 11:30 ` [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map Shawn Guo
2021-04-09 18:46 ` Rob Herring [this message]
2021-04-12 1:19 ` Shawn Guo
2021-04-13 12:43 ` Arend van Spriel
2021-04-11 7:57 ` Kalle Valo
2021-04-12 1:25 ` Shawn Guo
2021-04-12 11:54 ` Kalle Valo
2021-04-13 7:28 ` Shawn Guo
2021-04-12 7:48 ` Arend van Spriel
2021-04-08 11:30 ` [PATCH 2/2] brcmfmac: support parse country code map from DT Shawn Guo
2021-04-12 8:09 ` Arend van Spriel
2021-04-13 7:45 ` Shawn Guo
2021-04-13 8:10 ` Arend van Spriel
2021-04-12 8:22 ` Arend van Spriel
2021-04-13 7:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409184606.GA3937918@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=devicetree@vger.kernel.org \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=shawn.guo@linaro.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).