From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Radoslaw Tyl <radoslawx.tyl@intel.com>,
netdev@vger.kernel.org, sassmann@redhat.com,
anthony.l.nguyen@intel.com,
Tony Brelinski <tonyx.brelinski@intel.com>
Subject: [PATCH net-next 2/4] ixgbe: aggregate of all receive errors through netdev's rx_errors
Date: Fri, 9 Apr 2021 12:03:12 -0700 [thread overview]
Message-ID: <20210409190314.946192-3-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210409190314.946192-1-anthony.l.nguyen@intel.com>
From: Radoslaw Tyl <radoslawx.tyl@intel.com>
The global rx error does not take into account all the error counters
that are counted by device.
Extend rx error with the following counters:
- illegal byte error
- number of receive fragment errors
- receive jabber
- receive oversize error
- receive undersize error
- frames marked as checksum invalid by hardware
The above were added in order to align statistics with other products.
Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 7ba1c2985ef7..7711828401d9 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7240,12 +7240,21 @@ void ixgbe_update_stats(struct ixgbe_adapter *adapter)
hwstats->ptc1023 += IXGBE_READ_REG(hw, IXGBE_PTC1023);
hwstats->ptc1522 += IXGBE_READ_REG(hw, IXGBE_PTC1522);
hwstats->bptc += IXGBE_READ_REG(hw, IXGBE_BPTC);
+ hwstats->illerrc += IXGBE_READ_REG(hw, IXGBE_ILLERRC);
/* Fill out the OS statistics structure */
netdev->stats.multicast = hwstats->mprc;
/* Rx Errors */
- netdev->stats.rx_errors = hwstats->crcerrs + hwstats->rlec;
+ netdev->stats.rx_errors = hwstats->crcerrs +
+ hwstats->illerrc +
+ hwstats->rlec +
+ hwstats->rfc +
+ hwstats->rjc +
+ hwstats->roc +
+ hwstats->ruc +
+ hw_csum_rx_error;
+
netdev->stats.rx_dropped = 0;
netdev->stats.rx_length_errors = hwstats->rlec;
netdev->stats.rx_crc_errors = hwstats->crcerrs;
--
2.26.2
next prev parent reply other threads:[~2021-04-09 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 19:03 [PATCH net-next 0/4][pull request] 10GbE Intel Wired LAN Driver Updates 2021-04-09 Tony Nguyen
2021-04-09 19:03 ` [PATCH net-next 1/4] ixgbe: Support external GBE SerDes PHY BCM54616s Tony Nguyen
2021-04-09 19:03 ` Tony Nguyen [this message]
2021-04-10 1:00 ` [PATCH net-next 2/4] ixgbe: aggregate of all receive errors through netdev's rx_errors Jakub Kicinski
2021-04-13 23:52 ` Nguyen, Anthony L
2021-04-09 19:03 ` [PATCH net-next 3/4] net: intel: Remove unused function pointer typedef ixgbe_mc_addr_itr Tony Nguyen
2021-04-09 19:03 ` [PATCH net-next 4/4] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409190314.946192-3-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=radoslawx.tyl@intel.com \
--cc=sassmann@redhat.com \
--cc=tonyx.brelinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).