From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3820AC433B4 for ; Fri, 9 Apr 2021 20:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BAEA61181 for ; Fri, 9 Apr 2021 20:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234351AbhDIUke (ORCPT ); Fri, 9 Apr 2021 16:40:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37471 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231946AbhDIUkd (ORCPT ); Fri, 9 Apr 2021 16:40:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618000819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q193xZr1BMYRCl6sJseS6djVgHOxLnB/RXmKWcvH1Ro=; b=RICn4UlyJws681foM51ayuyHoY92Yq/WlHkF9axS57L85V1gqZy7I9yVTMXmXQ/7f91t2P GYqLjTY4VKerT8rFr6fLQCALHoC5xBdJZVBgS9RY6AsqWKJ6pvZHUMOoL21CoBNTCM0/pK UJLdp1ouOGlKCxPJ97tKQMux5w9P+jk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-tXkxNBTDO2CqPBZqDhxCrg-1; Fri, 09 Apr 2021 16:40:15 -0400 X-MC-Unique: tXkxNBTDO2CqPBZqDhxCrg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1978A107ACCD; Fri, 9 Apr 2021 20:40:13 +0000 (UTC) Received: from carbon (unknown [10.36.110.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id D29B16EF50; Fri, 9 Apr 2021 20:40:06 +0000 (UTC) Date: Fri, 9 Apr 2021 22:40:05 +0200 From: Jesper Dangaard Brouer To: Ilias Apalodimas Cc: brouer@redhat.com, Jakub Kicinski , Matteo Croce , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Lemon , "David S. Miller" , Jesper Dangaard Brouer , Lorenzo Bianconi , Saeed Mahameed , David Ahern , Saeed Mahameed , Andrew Lunn Subject: Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling Message-ID: <20210409224005.6dc6dcd6@carbon> In-Reply-To: References: <20210402181733.32250-1-mcroce@linux.microsoft.com> <20210402181733.32250-4-mcroce@linux.microsoft.com> <20210409115648.169523fd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce > > > Signed-off-by: Ilias Apalodimas > > > > Checkpatch says we need sign-offs from all authors. > > Especially you since you're posting. > > Yes it does, we forgot that. Let me take a chance on this one. > The patch is changing the default skb return path and while we've done enough > testing, I would really prefer this going in on a future -rc1 (assuming we even > consider merging it), allowing enough time to have wider tests. You can have my: Signed-off-by: Jesper Dangaard Brouer But as Ilias suggested in IRC lets send a V3, and Cc the MM-people, as this also dig into their area. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer