From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18312C433B4 for ; Mon, 12 Apr 2021 01:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9794606A5 for ; Mon, 12 Apr 2021 01:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236354AbhDLBT3 (ORCPT ); Sun, 11 Apr 2021 21:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235323AbhDLBT2 (ORCPT ); Sun, 11 Apr 2021 21:19:28 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A613AC06138C for ; Sun, 11 Apr 2021 18:19:11 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id i190so8122028pfc.12 for ; Sun, 11 Apr 2021 18:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kOVEUZxKUzw5yKV3UzpP1C8KkT2dA4aQzXOrSWS1c5s=; b=H2wD8qXLEIbcWHbeeSK56pfYG+r0PaLtaDxA+T5ueDArj3OfFJbkk9HBIf7sx9KPhO qrV3RLfszPLe9E5Ycxp1uzvaoGTFrMU0oiRrq5pp+xAtgSO9kC0BFAHLrAk152jY/rIc 5/fUGWZDALdmFv/Bc2LwFy4WVGxUBG2qId4We4719D7RF3BOYJeTZBkacpkQHtEydXV/ KvVEyZH0dr8EYn4HNPHUjvQBnxiMdITkcfj72xGVqeepYTKYKLS1gSZAqfWaLa+ZUld9 RLaxLnMzz2ldt+0sKhqyNHScZ0LNN/WAHfBugBB5v6mWMEYsggwUPojtpBcZ47CZBZDK rcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kOVEUZxKUzw5yKV3UzpP1C8KkT2dA4aQzXOrSWS1c5s=; b=J8kAzXkZLuZNT0cLmVDB3IY7bPonoA1N/acK11C2tmWG2jn0vEIIF9QJ6ecIZg0bwj xZbBxoyRy/sXwnUdAp/JdFdcbXuQuRQQfSYUYK4j4+iVUumVmrUbaB1KRUlUielCTJYE 57mKlPW00B89ZrdxegEEnfFzFailaPESsYSR35VYiOJ+HGdBUf89Gj2HdC+u5uLowoTG x0jUDns6nO2DKSbPH5EIKDtentvAePVxKtUfGKo/TmzA2UDuQTPbgg2FGZE9NZN8zFKY wdh6dA7atqBzhZjc1l5uAUkfX/MKQKhkFyyJTizAc1pzvs+9asQdCf0kKuCtqtYysAhx 0Cfw== X-Gm-Message-State: AOAM532ssmWepRKBOpcrxzd2kEmdaodOF4JmHSGe9jplMKbJ3SVjnV7q lU6izttrCltibJiliA1g/NM9mg== X-Google-Smtp-Source: ABdhPJyYY8bXAkVUCN6156iGSWFTJ3daOgQEdJrFUj6OF2GV0aKJW9nsdxYVbYgshCW5j+gxQKJsMg== X-Received: by 2002:a63:77cf:: with SMTP id s198mr24458053pgc.252.1618190351123; Sun, 11 Apr 2021 18:19:11 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id q22sm7755303pfk.2.2021.04.11.18.19.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Apr 2021 18:19:10 -0700 (PDT) Date: Mon, 12 Apr 2021 09:19:03 +0800 From: Shawn Guo To: Rob Herring Cc: Kalle Valo , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Subject: Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map Message-ID: <20210412011902.GA15093@dragon> References: <20210408113022.18180-1-shawn.guo@linaro.org> <20210408113022.18180-2-shawn.guo@linaro.org> <20210409184606.GA3937918@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409184606.GA3937918@robh.at.kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 09, 2021 at 01:46:06PM -0500, Rob Herring wrote: > On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote: > > Add optional brcm,ccode-map property to support translation from ISO3166 > > country code to brcmfmac firmware country code and revision. > > > > Signed-off-by: Shawn Guo > > --- > > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Can you convert this to schema first. Yes. Will do, after driver maintainers agree with the direction. > > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > index cffb2d6876e3..a65ac4384c04 100644 > > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > @@ -15,6 +15,12 @@ Optional properties: > > When not specified the device will use in-band SDIO interrupts. > > - interrupt-names : name of the out-of-band interrupt, which must be set > > to "host-wake". > > + - brcm,ccode-map : multiple strings for translating ISO3166 country code to > > + brcmfmac firmware country code and revision. Each string must be in > > + format "AA-BB-num" where: > > + AA is the ISO3166 country code which must be 2 characters. > > + BB is the firmware country code which must be 2 characters. > > + num is the revision number which must fit into signed integer. > > Signed? So "AA-BB--num"? Hmm, for some reason, kernel driver uses signed integer to hold the revision. It's just a reflecting of that. > > You should be able to do something like: > > items: > pattern: '^[A-Z][A-Z]-[A-Z][A-Z]-[0-9]+$' Ah, yes, that's much better and distinct. Thanks for the suggestion. Shawn > > > > > Example: > > > > @@ -34,5 +40,6 @@ mmc3: mmc@1c12000 { > > interrupt-parent = <&pio>; > > interrupts = <10 8>; /* PH10 / EINT10 */ > > interrupt-names = "host-wake"; > > + brcm,ccode-map = "JP-JP-78", "US-Q2-86"; > > }; > > }; > > -- > > 2.17.1 > >