From: Stefano Garzarella <sgarzare@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: mst@redhat.com, jasowang@redhat.com, si-wei.liu@oracle.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] vdpa/mlx5: Set err = -ENOMEM in case dma_map_sg_attrs fails
Date: Mon, 12 Apr 2021 14:49:35 +0200 [thread overview]
Message-ID: <20210412124935.jtguuf7dj74eezcw@steredhat> (raw)
In-Reply-To: <20210411083646.910546-1-elic@nvidia.com>
On Sun, Apr 11, 2021 at 11:36:46AM +0300, Eli Cohen wrote:
>Set err = -ENOMEM if dma_map_sg_attrs() fails so the function reutrns
>error.
>
>Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
>Signed-off-by: Eli Cohen <elic@nvidia.com>
>Reported-by: kernel test robot <lkp@intel.com>
>Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>---
> drivers/vdpa/mlx5/core/mr.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/vdpa/mlx5/core/mr.c b/drivers/vdpa/mlx5/core/mr.c
>index 3908ff28eec0..800cfd1967ad 100644
>--- a/drivers/vdpa/mlx5/core/mr.c
>+++ b/drivers/vdpa/mlx5/core/mr.c
>@@ -278,8 +278,10 @@ static int map_direct_mr(struct mlx5_vdpa_dev *mvdev, struct mlx5_vdpa_direct_mr
> mr->log_size = log_entity_size;
> mr->nsg = nsg;
> mr->nent = dma_map_sg_attrs(dma, mr->sg_head.sgl, mr->nsg, DMA_BIDIRECTIONAL, 0);
>- if (!mr->nent)
>+ if (!mr->nent) {
>+ err = -ENOMEM;
> goto err_map;
>+ }
>
> err = create_direct_mr(mvdev, mr);
> if (err)
>--
>2.30.1
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
prev parent reply other threads:[~2021-04-12 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 8:36 [PATCH] vdpa/mlx5: Set err = -ENOMEM in case dma_map_sg_attrs fails Eli Cohen
2021-04-12 9:45 ` Jason Wang
2021-04-12 12:49 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412124935.jtguuf7dj74eezcw@steredhat \
--to=sgarzare@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=lkp@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).