From: Jason Gunthorpe <jgg@nvidia.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ertman, David M" <david.m.ertman@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Hefty, Sean" <sean.hefty@intel.com>
Subject: Re: [PATCH v4 resend 01/23] iidc: Introduce iidc.h
Date: Mon, 12 Apr 2021 13:12:29 -0300 [thread overview]
Message-ID: <20210412161229.GA1115687@nvidia.com> (raw)
In-Reply-To: <2ee289f620154810921df2bc2c903192@intel.com>
On Mon, Apr 12, 2021 at 02:51:18PM +0000, Saleem, Shiraz wrote:
> > Where is ftype initialized?
>
> Today it is just pf. But the upcoming Intel ethernet VF driver will
> set it to true.
Then it is dead code, don't send dead code to the kernel.
> > This cdev_info should just be a 'struct ice_pf *' and the "struct
> > iidc_core_dev_info" should be deleted entirely. You'll notice this
> > ends up looking nearly exactly like mlx5 does after this.
>
> It was intentionally designed to be core device object carving out
> only pieces of the PF information required by the rdma driver. The
> next near-term PCI driver using IIDC can also this. Why expose the
> whole PF? This is a design choice no? Why do we need to follow mlx5?
When you get around to building your multi-driver API it should be
structured so it doesn't have a de-normalization of the data - don't
copy from one authoritative struct to some other struct just to get
some weird information hiding.
The PF driver should be a subclass if your "generic" driver and
directly embed some struct like this as the singular canonical source
of information, not be duplicated.
> I don't follow what the hackery is. Just because we use cdev_info in
> the .ops callbacks as opposed to ice_pf?
There are too many signs to ignore:
- The obfuscated extensible structs being passed into ops that are
only encoding a couple function call parameters
- The ops that only have one implementation
- The struct that is a complete copy of a different, but "internal",
struct
You do stuff like this to make stable ABIs. This is forbidden by Linus
for in-kernel APIs, and it is not the kernel style in general to code
like this.
Jason
next prev parent reply other threads:[~2021-04-12 16:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 0:14 [PATCH v4 resend 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma) Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 01/23] iidc: Introduce iidc.h Shiraz Saleem
2021-04-07 18:05 ` Jason Gunthorpe
2021-04-12 14:51 ` Saleem, Shiraz
2021-04-12 16:12 ` Jason Gunthorpe [this message]
2021-04-07 0:14 ` [PATCH v4 resend 02/23] ice: Initialize RDMA support Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 03/23] ice: Implement iidc operations Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 04/23] ice: Register auxiliary device to provide RDMA Shiraz Saleem
2021-04-07 17:45 ` Jason Gunthorpe
2021-04-12 14:51 ` Saleem, Shiraz
2021-04-07 0:14 ` [PATCH v4 resend 05/23] ice: Add devlink params support Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 06/23] i40e: Prep i40e header for aux bus conversion Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 07/23] i40e: Register auxiliary devices to provide RDMA Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 08/23] RDMA/irdma: Register auxiliary driver and implement private channel OPs Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 09/23] RDMA/irdma: Implement device initialization definitions Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 10/23] RDMA/irdma: Implement HW Admin Queue OPs Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 11/23] RDMA/irdma: Add HMC backing store setup functions Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 12/23] RDMA/irdma: Add privileged UDA queue implementation Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 13/23] RDMA/irdma: Add QoS definitions Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 14/23] RDMA/irdma: Add connection manager Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 15/23] RDMA/irdma: Add PBLE resource manager Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 16/23] RDMA/irdma: Implement device supported verb APIs Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 17/23] RDMA/irdma: Add RoCEv2 UD OP support Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 18/23] RDMA/irdma: Add user/kernel shared libraries Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 19/23] RDMA/irdma: Add miscellaneous utility definitions Shiraz Saleem
2021-04-07 0:14 ` [PATCH v4 resend 20/23] RDMA/irdma: Add dynamic tracing for CM Shiraz Saleem
2021-04-07 0:15 ` [PATCH v4 resend 21/23] RDMA/irdma: Add ABI definitions Shiraz Saleem
2021-04-07 15:23 ` Jason Gunthorpe
2021-04-07 20:57 ` Saleem, Shiraz
2021-04-07 0:15 ` [PATCH v4 resend 22/23] RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw Shiraz Saleem
2021-04-07 0:15 ` [PATCH v4 resend 23/23] RDMA/irdma: Update MAINTAINERS file Shiraz Saleem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412161229.GA1115687@nvidia.com \
--to=jgg@nvidia.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dledford@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).