From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: "Håkon Bugge" <haakon.bugge@oracle.com>,
"Santosh Shilimkar" <santosh.shilimkar@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
"Doug Ledford" <dledford@redhat.com>,
linux-rdma@vger.kernel.org, "Parav Pandit" <parav@nvidia.com>,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS
Date: Tue, 13 Apr 2021 10:51:20 -0300 [thread overview]
Message-ID: <20210413135120.GT7405@nvidia.com> (raw)
In-Reply-To: <YHU6VXP6kZABXIYA@unreal>
On Tue, Apr 13, 2021 at 09:29:41AM +0300, Leon Romanovsky wrote:
> On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote:
> > On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote:
> > > ib_modify_qp() is an expensive operation on some HCAs running
> > > virtualized. This series removes two ib_modify_qp() calls from RDS.
> > >
> > > I am sending this as a v3, even though it is the first sent to
> > > net. This because the IB Core commit has reach v3.
> > >
> > > Håkon Bugge (2):
> > > IB/cma: Introduce rdma_set_min_rnr_timer()
> > > rds: ib: Remove two ib_modify_qp() calls
> >
> > Applied to rdma for-next, thanks
>
> Jason,
>
> It should be
> + WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_TGT);
>
> and not
> + if (WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_TGT))
> + return -EINVAL;
Unless we can completely remove the return code the if statement is a
reasonable way to use the WARN_ON here
Jason
prev parent reply other threads:[~2021-04-13 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 18:43 [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS Håkon Bugge
2021-03-31 18:43 ` [PATCH for-next v3 1/2] IB/cma: Introduce rdma_set_min_rnr_timer() Håkon Bugge
2021-04-01 10:54 ` Leon Romanovsky
2021-03-31 18:43 ` [PATCH for-next v3 2/2] rds: ib: Remove two ib_modify_qp() calls Håkon Bugge
2021-03-31 19:54 ` [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS Santosh Shilimkar
2021-04-01 17:51 ` Jason Gunthorpe
2021-04-07 16:41 ` Haakon Bugge
2021-04-12 18:35 ` Haakon Bugge
2021-04-12 18:45 ` Jason Gunthorpe
2021-04-12 22:58 ` Jason Gunthorpe
2021-04-13 6:29 ` Leon Romanovsky
2021-04-13 11:13 ` Haakon Bugge
2021-04-13 11:37 ` Leon Romanovsky
2021-04-13 13:51 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413135120.GT7405@nvidia.com \
--to=jgg@nvidia.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).