From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Cc: steffen.klassert@secunet.com, davem@davemloft.net,
kuba@kernel.org, herbert@gondor.apana.org.au,
Florian Westphal <fw@strlen.de>
Subject: [PATCH ipsec-next 2/3] xfrm: remove stray synchronize_rcu from xfrm_init
Date: Wed, 14 Apr 2021 18:12:52 +0200 [thread overview]
Message-ID: <20210414161253.27586-3-fw@strlen.de> (raw)
In-Reply-To: <20210414161253.27586-1-fw@strlen.de>
This function is called during boot, from ipv4 stack, there is no need
to set the pointer to NULL (static storage duration, so already NULL).
No need for the synchronize_rcu either. Remove both.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/xfrm/xfrm_policy.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index c49f20657cdb..59691611a9ab 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -4134,9 +4134,6 @@ void __init xfrm_init(void)
#ifdef CONFIG_XFRM_ESPINTCP
espintcp_init();
#endif
-
- RCU_INIT_POINTER(xfrm_if_cb, NULL);
- synchronize_rcu();
}
#ifdef CONFIG_AUDITSYSCALL
--
2.26.3
next prev parent reply other threads:[~2021-04-14 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 16:12 [PATCH ipsec-next 0/3] xfrm: minor cleanup and synchronize_rcu removal Florian Westphal
2021-04-14 16:12 ` [PATCH ipsec-next 1/3] flow: remove spi key from flowi struct Florian Westphal
2021-04-14 16:12 ` Florian Westphal [this message]
2021-04-14 16:12 ` [PATCH ipsec-next 3/3] xfrm: avoid synchronize_rcu during netns destruction Florian Westphal
2021-04-20 11:56 ` [PATCH ipsec-next 0/3] xfrm: minor cleanup and synchronize_rcu removal Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414161253.27586-3-fw@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).