From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8194C433ED for ; Wed, 14 Apr 2021 20:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CB8861177 for ; Wed, 14 Apr 2021 20:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245615AbhDNUiX (ORCPT ); Wed, 14 Apr 2021 16:38:23 -0400 Received: from elvis.franken.de ([193.175.24.41]:50505 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbhDNUiU (ORCPT ); Wed, 14 Apr 2021 16:38:20 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lWmGp-0007TK-00; Wed, 14 Apr 2021 22:37:55 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C3C85C035A; Wed, 14 Apr 2021 22:36:56 +0200 (CEST) Date: Wed, 14 Apr 2021 22:36:56 +0200 From: Thomas Bogendoerfer To: Andrew Lunn Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/7] net: korina: Fix MDIO functions Message-ID: <20210414203656.GA3382@alpha.franken.de> References: <20210413204818.23350-1-tsbogend@alpha.franken.de> <20210413204818.23350-2-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 14, 2021 at 09:36:04PM +0200, Andrew Lunn wrote: > > +static int korina_mdio_wait(struct korina_private *lp) > > +{ > > + int timeout = 1000; > > + > > + while ((readl(&lp->eth_regs->miimind) & 1) && timeout-- > 0) > > + udelay(1); > > + > > + if (timeout <= 0) > > + return -1; > > + > > + return 0; > > Using readl_poll_timeout_atomic() would be better. I'll have a look > > > > +} > > + > > +static int korina_mdio_read(struct net_device *dev, int phy, int reg) > > { > > struct korina_private *lp = netdev_priv(dev); > > int ret; > > > > - mii_id = ((lp->rx_irq == 0x2c ? 1 : 0) << 8); > > + if (korina_mdio_wait(lp)) > > + return -1; > > This should really be -ETIMEDOUT ok. > > dev->watchdog_timeo = TX_TIMEOUT; > > netif_napi_add(dev, &lp->napi, korina_poll, NAPI_POLL_WEIGHT); > > > > - lp->phy_addr = (((lp->rx_irq == 0x2c? 1:0) << 8) | 0x05); > > lp->mii_if.dev = dev; > > - lp->mii_if.mdio_read = mdio_read; > > - lp->mii_if.mdio_write = mdio_write; > > - lp->mii_if.phy_id = lp->phy_addr; > > + lp->mii_if.mdio_read = korina_mdio_read; > > + lp->mii_if.mdio_write = korina_mdio_write; > > + lp->mii_if.phy_id = 1; > > lp->mii_if.phy_id_mask = 0x1f; > > lp->mii_if.reg_num_mask = 0x1f; > > You could also replace all the mii code with phylib. that's on my todo. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]