From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, Grzegorz Siwik <grzegorz.siwik@intel.com>,
netdev@vger.kernel.org, sassmann@redhat.com,
Dave Switzer <david.switzer@intel.com>
Subject: Re: [PATCH net-next 2/6] igb: Add double-check MTA_REGISTER for i210 and i211
Date: Fri, 16 Apr 2021 14:12:47 -0700 [thread overview]
Message-ID: <20210416141247.7a8048ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210416204500.2012073-3-anthony.l.nguyen@intel.com>
On Fri, 16 Apr 2021 13:44:56 -0700 Tony Nguyen wrote:
> + bool is_failed;
> + int i;
> +
> + do {
> + is_failed = false;
> + for (i = hw->mac.mta_reg_count - 1; i >= 0; i--) {
> + if (array_rd32(E1000_MTA, i) != hw->mac.mta_shadow[i]) {
> + is_failed = true;
> + array_wr32(E1000_MTA, i, hw->mac.mta_shadow[i]);
> + wrfl();
> + break;
> + }
> + }
> + } while (is_failed);
Looks like a potential infinite loop on persistent failure.
Also you don't need "is_failed", you can use while (i >= 0), or
assign i = hw->mac.mta_reg_count, or consider using a goto.
next prev parent reply other threads:[~2021-04-16 21:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 20:44 [PATCH net-next 0/6][pull request] 1GbE Intel Wired LAN Driver Updates 2021-04-16 Tony Nguyen
2021-04-16 20:44 ` [PATCH net-next 1/6] igb: Redistribute memory for transmit packet buffers when in Qav mode Tony Nguyen
2021-04-16 20:44 ` [PATCH net-next 2/6] igb: Add double-check MTA_REGISTER for i210 and i211 Tony Nguyen
2021-04-16 21:12 ` Jakub Kicinski [this message]
2021-04-20 16:22 ` Nguyen, Anthony L
2021-05-10 13:43 ` Nick Lowe
2021-05-10 14:01 ` Nick Lowe
2021-05-13 12:19 ` Siwik, Grzegorz
2021-04-16 20:44 ` [PATCH net-next 3/6] igc: Enable internal i225 PPS Tony Nguyen
2021-04-16 20:44 ` [PATCH net-next 4/6] igc: enable auxiliary PHC functions for the i225 Tony Nguyen
2021-04-16 20:44 ` [PATCH net-next 5/6] igc: Fix overwrites return value Tony Nguyen
2021-04-16 20:45 ` [PATCH net-next 6/6] igc: Expose LPI counters Tony Nguyen
2021-04-17 0:20 ` [PATCH net-next 0/6][pull request] 1GbE Intel Wired LAN Driver Updates 2021-04-16 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416141247.7a8048ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.switzer@intel.com \
--cc=grzegorz.siwik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).