From: David Miller <davem@davemloft.net>
To: m.chetan.kumar@intel.com
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
johannes@sipsolutions.net, krishna.c.sudi@intel.com,
linuxwwan@intel.com
Subject: Re: [PATCH V2 02/16] net: iosm: irq handling
Date: Tue, 20 Apr 2021 16:48:02 -0700 (PDT) [thread overview]
Message-ID: <20210420.164802.229687091665923532.davem@davemloft.net> (raw)
In-Reply-To: <20210420161310.16189-3-m.chetan.kumar@intel.com>
From: M Chetan Kumar <m.chetan.kumar@intel.com>
Date: Tue, 20 Apr 2021 21:42:56 +0530
> 1) Request interrupt vector, frees allocated resource.
> 2) Registers IRQ handler.
>
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@intel.com>
> ---
> v2: Streamline multiple returns using goto.
> ---
> drivers/net/wwan/iosm/iosm_ipc_irq.c | 91 ++++++++++++++++++++++++++++
> drivers/net/wwan/iosm/iosm_ipc_irq.h | 33 ++++++++++
> 2 files changed, 124 insertions(+)
> create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.c
> create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.h
>
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_irq.c b/drivers/net/wwan/iosm/iosm_ipc_irq.c
> new file mode 100644
> index 000000000000..a3e017604fa4
> --- /dev/null
> +++ b/drivers/net/wwan/iosm/iosm_ipc_irq.c
> @@ -0,0 +1,91 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2020-21 Intel Corporation.
> + */
> +
> +#include "iosm_ipc_pcie.h"
> +#include "iosm_ipc_protocol.h"
> +
> +static inline void write_dbell_reg(struct iosm_pcie *ipc_pcie, int irq_n,
> + u32 data)
Please do not use inline in foo.c files, let the compiler decide.
Thank you.
next prev parent reply other threads:[~2021-04-20 23:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 16:12 [PATCH V2 00/16] net: iosm: PCIe Driver for Intel M.2 Modem M Chetan Kumar
2021-04-20 16:12 ` [PATCH V2 01/16] net: iosm: entry point M Chetan Kumar
2021-04-21 5:44 ` Leon Romanovsky
2021-04-21 6:51 ` Johannes Berg
2021-04-21 8:03 ` Leon Romanovsky
2021-04-20 16:12 ` [PATCH V2 02/16] net: iosm: irq handling M Chetan Kumar
2021-04-20 23:48 ` David Miller [this message]
2021-04-20 16:12 ` [PATCH V2 03/16] net: iosm: mmio scratchpad M Chetan Kumar
2021-04-20 16:12 ` [PATCH V2 04/16] net: iosm: shared memory IPC interface M Chetan Kumar
2021-04-20 16:12 ` [PATCH V2 05/16] net: iosm: shared memory I/O operations M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 06/16] net: iosm: channel configuration M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 07/16] net: iosm: mbim control device M Chetan Kumar
2021-05-06 9:25 ` Loic Poulain
2021-05-06 10:44 ` Kumar, M Chetan
2021-05-06 14:09 ` Dan Williams
2021-04-20 16:13 ` [PATCH V2 08/16] net: iosm: bottom half M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 09/16] net: iosm: multiplex IP sessions M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 10/16] net: iosm: encode or decode datagram M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 11/16] net: iosm: power management M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 12/16] net: iosm: shared memory protocol M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 13/16] net: iosm: protocol operations M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 14/16] net: iosm: uevent support M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 15/16] net: iosm: net driver M Chetan Kumar
2021-04-20 16:13 ` [PATCH V2 16/16] net: iosm: infrastructure M Chetan Kumar
2021-04-20 18:08 ` Randy Dunlap
2021-05-06 8:54 ` [PATCH V2 00/16] net: iosm: PCIe Driver for Intel M.2 Modem Aleksander Morgado
2021-05-06 10:51 ` Kumar, M Chetan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420.164802.229687091665923532.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=krishna.c.sudi@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwwan@intel.com \
--cc=m.chetan.kumar@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).