netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tony Ambardar <tony.ambardar@gmail.com>
Cc: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2] ip: drop 2-char command assumption
Date: Tue, 20 Apr 2021 08:16:08 -0700	[thread overview]
Message-ID: <20210420081608.3287f75f@hermes.local> (raw)
In-Reply-To: <20210420082636.1210305-1-Tony.Ambardar@gmail.com>

On Tue, 20 Apr 2021 01:26:36 -0700
Tony Ambardar <tony.ambardar@gmail.com> wrote:

> The 'ip' utility hardcodes the assumption of being a 2-char command, where
> any follow-on characters are passed as an argument:
> 
>   $ ./ip-full help
>   Object "-full" is unknown, try "ip help".
> 
> This confusing behaviour isn't seen with 'tc' for example, and was added in
> a 2005 commit without documentation. It was noticed during testing of 'ip'
> variants built/packaged with different feature sets (e.g. w/o BPF support).
> 
> Mitigate the problem by redoing the command without the 2-char assumption
> if the follow-on characters fail to parse as a valid command.
> 
> Fixes: 351efcde4e62 ("Update header files to 2.6.14")
> Signed-off-by: Tony Ambardar <Tony.Ambardar@gmail.com>
> ---
> v2: (feedback from David Ahern)
>   * work around problem but remain compatible with 2-char assumption

I am ok with this, but if you change the name of command, you can expect some
friction (and non support).

The original commit was inherited from the original integration of tarball's
into BitKeeper. This "feature" was put in by Alexey Kuznetsov back in orignal 2.4
time frame.

  reply	other threads:[~2021-04-20 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18  3:49 [PATCH iproute2] ip: drop 2-char command assumption Tony Ambardar
2021-04-18 17:18 ` David Ahern
2021-04-20  8:26   ` [PATCH iproute2 v2] " Tony Ambardar
2021-04-20 15:16     ` Stephen Hemminger [this message]
2021-04-21  4:49       ` Tony Ambardar
2021-04-26  2:31     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210420081608.3287f75f@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tony.ambardar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).