From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93CCFC433B4 for ; Fri, 23 Apr 2021 18:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A28061207 for ; Fri, 23 Apr 2021 18:07:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243472AbhDWSIG (ORCPT ); Fri, 23 Apr 2021 14:08:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhDWSIE (ORCPT ); Fri, 23 Apr 2021 14:08:04 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316FCC061574; Fri, 23 Apr 2021 11:07:28 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 542AE72B7; Fri, 23 Apr 2021 14:07:27 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 542AE72B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1619201247; bh=1HWABe1pBrZRNSlmKUpJ27EmxvYwRlFblgJzINxdFHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JlB/RqCRZaUXv2F0AHjVjc3KWpwwU4LxrmDVK6vAeG1GIUxukeByBcG/m9U9lC07c 0nDtoSvfa03M+d6ch3T1BXdAOl8dHXLZ172qYuet4JoV6VO+GtC56Mt1/ezM3QR+cC Fuwo+9UJBWVIK3HYFSB/yqdy+ACYYvsRkJE8MURs= Date: Fri, 23 Apr 2021 14:07:27 -0400 From: "J. Bruce Fields" To: Leon Romanovsky Cc: "Shelat, Abhi" , Greg KH , Sudip Mukherjee , Aditya Pakki , Chuck Lever , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , Dave Wysochanski , "linux-nfs@vger.kernel.org" , netdev , linux-kernel Subject: Re: [PATCH] SUNRPC: Add a check for gss_release_msg Message-ID: <20210423180727.GD10457@fieldses.org> References: <3B9A54F7-6A61-4A34-9EAC-95332709BAE7@northeastern.edu> <20210421133727.GA27929@fieldses.org> <20210421135637.GB27929@fieldses.org> <20210422193950.GA25415@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 23, 2021 at 08:25:28PM +0300, Leon Romanovsky wrote: > On Thu, Apr 22, 2021 at 03:39:50PM -0400, J. Bruce Fields wrote: > > On Wed, Apr 21, 2021 at 09:56:37AM -0400, J. Bruce Fields wrote: > > > On Wed, Apr 21, 2021 at 04:49:31PM +0300, Leon Romanovsky wrote: > > > > If you want to see another accepted patch that is already part of > > > > stable@, you are invited to take a look on this patch that has "built-in bug": > > > > 8e949363f017 ("net: mlx5: Add a missing check on idr_find, free buf") > > > > > > Interesting, thanks. > > > > Though looking at it now, I'm not actually seeing the bug--probably I'm > > overlooking something obvious. > > It was fixed in commit 31634bf5dcc4 ("net/mlx5: FPGA, tls, hold rcu read lock a bit longer") So is the "Fixes:" line on that commit wrong? It claims the bug was introduced by an earlier commit, ab412e1dd7db ("net/mlx5: Accel, add TLS rx offload routines"). Looks like Aditya Pakki's commit may have widened the race a little, but I find it a little hard to fault him for that. --b.