From: kernel test robot <lkp@intel.com>
To: "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org, richardcochran@gmail.com
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Subject: [PATCH] phy: nxp-c45-tja11xx: fix boolconv.cocci warnings
Date: Thu, 29 Apr 2021 00:07:28 +0800 [thread overview]
Message-ID: <20210428160728.GA36275@86b226db57a6> (raw)
In-Reply-To: <20210428123013.127571-3-radu-nicolae.pirea@oss.nxp.com>
From: kernel test robot <lkp@intel.com>
drivers/net/phy/nxp-c45-tja11xx.c:269:25-30: WARNING: conversion to bool not needed here
Remove unneeded conversion to bool
Semantic patch information:
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Generated by: scripts/coccinelle/misc/boolconv.cocci
CC: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Radu-Pirea-NXP-OSS/Add-PTP-support-for-TJA1103/20210428-203250
base: a5fb44b89809a00cfb85997529d8430ed0759ea5
nxp-c45-tja11xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -266,7 +266,7 @@ static int nxp_c45_ptp_adjfine(struct pt
u64 subns_inc_val;
bool inc;
- inc = ppb >= 0 ? true : false;
+ inc = ppb >= 0;
ppb = abs(ppb);
subns_inc_val = PPM_TO_SUBNS_INC(ppb);
next prev parent reply other threads:[~2021-04-28 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 12:30 [PATCH v1 0/2] Add PTP support for TJA1103 Radu Pirea (NXP OSS)
2021-04-28 12:30 ` [PATCH v1 1/2] ptp: ptp_clock: make scaled_ppm_to_ppb static inline Radu Pirea (NXP OSS)
2021-04-28 12:30 ` [PATCH v1 2/2] phy: nxp-c45-tja11xx: add timestamping support Radu Pirea (NXP OSS)
2021-04-28 16:07 ` kernel test robot
2021-04-28 16:07 ` kernel test robot [this message]
2021-04-29 15:11 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428160728.GA36275@86b226db57a6 \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).