From: Gal Pressman <galpress@amazon.com>
To: David Ahern <dsahern@gmail.com>
Cc: <linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>,
Yossi Leybovich <sleybo@amazon.com>,
Alexander Matushevsky <matua@amazon.com>,
Leon Romanovsky <leonro@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Gal Pressman <galpress@amazon.com>
Subject: [PATCH iproute2-next v2 2/2] rdma: Add copy-on-fork to get sys command
Date: Thu, 29 Apr 2021 09:48:03 +0300 [thread overview]
Message-ID: <20210429064803.58458-3-galpress@amazon.com> (raw)
In-Reply-To: <20210429064803.58458-1-galpress@amazon.com>
The new attribute indicates that the kernel copies DMA pages on fork,
hence fork support through madvise and MADV_DONTFORK is not needed.
If the attribute is not reported (expected on older kernels),
copy-on-fork is disabled.
Example:
$ rdma sys
netns shared copy-on-fork on
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
rdma/sys.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/rdma/sys.c b/rdma/sys.c
index 8fb565d70598..fd785b253e20 100644
--- a/rdma/sys.c
+++ b/rdma/sys.c
@@ -20,6 +20,7 @@ static const char *netns_modes_str[] = {
static int sys_show_parse_cb(const struct nlmsghdr *nlh, void *data)
{
struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
+ bool cof = false;
mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
@@ -35,9 +36,17 @@ static int sys_show_parse_cb(const struct nlmsghdr *nlh, void *data)
else
mode_str = "unknown";
- print_color_string(PRINT_ANY, COLOR_NONE, "netns", "netns %s\n",
+ print_color_string(PRINT_ANY, COLOR_NONE, "netns", "netns %s ",
mode_str);
}
+
+ if (tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK])
+ cof = mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]);
+
+ print_color_on_off(PRINT_ANY, COLOR_NONE, "copy-on-fork",
+ "copy-on-fork %s\n",
+ cof);
+
return MNL_CB_OK;
}
--
2.31.1
next prev parent reply other threads:[~2021-04-29 6:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 6:48 [PATCH iproute2-next v2 0/2] Add copy-on-fork to get sys command Gal Pressman
2021-04-29 6:48 ` [PATCH iproute2-next v2 1/2] rdma: update uapi headers Gal Pressman
2021-04-29 7:13 ` Leon Romanovsky
2021-04-29 6:48 ` Gal Pressman [this message]
2021-04-29 7:12 ` [PATCH iproute2-next v2 2/2] rdma: Add copy-on-fork to get sys command Leon Romanovsky
2021-05-03 14:44 ` [PATCH iproute2-next v2 0/2] " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429064803.58458-3-galpress@amazon.com \
--to=galpress@amazon.com \
--cc=dsahern@gmail.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).