From: Michal Kubecek <mkubecek@suse.cz>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, idosch@idosch.org
Subject: Re: [PATCH ethtool-next v2 5/7] ethtool: add nlchk for redirecting to netlink
Date: Sun, 2 May 2021 23:39:31 +0200 [thread overview]
Message-ID: <20210502213931.iqb6zyn6nlkiy7ke@lion.mk-sys.cz> (raw)
In-Reply-To: <20210422154050.3339628-6-kuba@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Thu, Apr 22, 2021 at 08:40:48AM -0700, Jakub Kicinski wrote:
> To support commands which differ from the ioctl implementation
> add a new callback which can check if the arguments on the command
> line indicate that the request should be sent over netlink.
> The decision should be inferred from the arguments, rather
> than an explicit --netlink argument.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This breaks build with --disable-netlink, the !ETHTOOL_ENABLE_NETLINK
version of netlink_run_handler() needs to be updated as well.
Other than this and the two minor nitpicks, the series looks good to me.
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-02 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 15:40 [PATCH ethtool-next v2 0/7] ethtool: support FEC and standard stats Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 1/7] update UAPI header copies Jakub Kicinski
2021-05-02 21:16 ` Michal Kubecek
2021-04-22 15:40 ` [PATCH ethtool-next v2 2/7] json: improve array print API Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 3/7] netlink: add FEC support Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 4/7] netlink: fec: support displaying statistics Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 5/7] ethtool: add nlchk for redirecting to netlink Jakub Kicinski
2021-05-02 21:39 ` Michal Kubecek [this message]
2021-04-22 15:40 ` [PATCH ethtool-next v2 6/7] netlink: add support for standard stats Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 7/7] netlink: stats: add on --all-groups option Jakub Kicinski
2021-05-02 21:36 ` Michal Kubecek
2021-05-03 15:59 ` Jakub Kicinski
2021-05-03 16:11 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210502213931.iqb6zyn6nlkiy7ke@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).