From: Ansuel Smith <ansuelsmth@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ansuel Smith <ansuelsmth@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org
Subject: [RFC PATCH net-next v2 00/17] Multiple improvement to qca8k stability
Date: Mon, 3 May 2021 01:07:10 +0200 [thread overview]
Message-ID: <20210502230710.30676-18-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20210502230710.30676-1-ansuelsmth@gmail.com>
Currently qca8337 switch are widely used on ipq8064 based router.
On these particular router it was notice a very unstable switch with
port not link detected as link with unknown speed, port dropping
randomly and general unreliability. Lots of testing and comparison
between this dsa driver and the original qsdk driver showed lack of some
additional delay and values. A main difference arised from the original
driver and the dsa one. The original driver didn't use MASTER regs to
read phy status and the dedicated mdio driver worked correctly. Now that
the dsa driver actually use these regs, it was found that these special
read/write operation required mutual exclusion to normal
qca8k_read/write operation. The add of mutex for these operation fixed
the random port dropping and now only the actual linked port randomly
dropped. Adding additional delay for set_page operation and fixing a bug
in the mdio dedicated driver fixed also this problem. The current driver
requires also more time to apply vlan switch. All of these changes and
tweak permit a now very stable and reliable dsa driver and 0 port
dropping. This series is currently tested by at least 5 user with
different routers and all reports positive results and no problems.
Changes v2:
- Implemented phy driver for internal PHYs
I'm testing cable test functions as I found some documentation that
actually declare regs about it. Problem is that it doesn't actually
work. It seems that the value set are ignored by the phy.
- Made the rgmii delay configurable
- Reordered patch
- Split mdio patches to more specific ones
- Reworked mdio driver to use readl/writel instead of regmap
- Reworked the entire driver to make it aware of any read/write error.
- Added phy generic patch to pass flags with phylink_connect_phy
function
A decision about the extra mdio delay is still to be taken but I
preferred to push a v2 since there is a new driver and more changes than
v0.
Ansuel Smith (17):
net: mdio: ipq8064: clean whitespaces in define
net: mdio: ipq8064: switch to write/readl function
net: mdio: ipq8064: enlarge sleep after read/write operation
net: dsa: qca8k: rework read/write/set_page to provide error
net: dsa: qca8k: add support for qca8327 switch
devicetree: net: dsa: qca8k: Document new compatible qca8327
net: dsa: qca8k: add priority tweak to qca8337 switch
net: dsa: qca8k: add GLOBAL_FC settings needed for qca8327
net: dsa: qca8k: add support for switch rev
net: dsa: qca8k: make rgmii delay configurable
net: dsa: qca8k: clear MASTER_EN after phy read/write
net: dsa: qca8k: dsa: qca8k: protect MASTER busy_wait with mdio mutex
net: dsa: qca8k: enlarge mdio delay and timeout
net: phy: phylink: permit to pass dev_flags to phylink_connect_phy
net: dsa: slave: pass dev_flags also to internal PHY
net: dsa: qca8k: pass switch_revision info to phy dev_flags
net: phy: add qca8k driver for qca8k switch internal PHY
.../devicetree/bindings/net/dsa/qca8k.txt | 1 +
drivers/net/dsa/qca8k.c | 649 ++++++++++++++----
drivers/net/dsa/qca8k.h | 54 +-
drivers/net/ethernet/cadence/macb_main.c | 2 +-
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
drivers/net/mdio/mdio-ipq8064.c | 64 +-
drivers/net/phy/Kconfig | 7 +
drivers/net/phy/Makefile | 1 +
drivers/net/phy/phylink.c | 12 +-
drivers/net/phy/qca8k.c | 174 +++++
include/linux/phylink.h | 2 +-
net/dsa/slave.c | 6 +-
12 files changed, 772 insertions(+), 202 deletions(-)
create mode 100644 drivers/net/phy/qca8k.c
--
2.30.2
prev parent reply other threads:[~2021-05-02 23:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 23:06 [RFC PATCH net-next v2 01/17] net: mdio: ipq8064: clean whitespaces in define Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 02/17] net: mdio: ipq8064: switch to write/readl function Ansuel Smith
2021-05-03 12:49 ` Andrew Lunn
2021-05-03 14:24 ` Ansuel Smith
2021-05-03 14:44 ` Andrew Lunn
2021-05-02 23:06 ` [RFC PATCH net-next v2 03/17] net: mdio: ipq8064: enlarge sleep after read/write operation Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 04/17] net: dsa: qca8k: rework read/write/set_page to provide error Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 05/17] net: dsa: qca8k: add support for qca8327 switch Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 06/17] devicetree: net: dsa: qca8k: Document new compatible qca8327 Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 07/17] net: dsa: qca8k: add priority tweak to qca8337 switch Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 08/17] net: dsa: qca8k: add GLOBAL_FC settings needed for qca8327 Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 09/17] net: dsa: qca8k: add support for switch rev Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 10/17] net: dsa: qca8k: make rgmii delay configurable Ansuel Smith
2021-05-03 0:54 ` Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 11/17] net: dsa: qca8k: clear MASTER_EN after phy read/write Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 12/17] net: dsa: qca8k: dsa: qca8k: protect MASTER busy_wait with mdio mutex Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 13/17] net: dsa: qca8k: enlarge mdio delay and timeout Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 14/17] net: phy: phylink: permit to pass dev_flags to phylink_connect_phy Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 15/17] net: dsa: slave: pass dev_flags also to internal PHY Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 16/17] net: dsa: qca8k: pass switch_revision info to phy dev_flags Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 17/17] net: phy: add qca8k driver for qca8k switch internal PHY Ansuel Smith
2021-05-02 23:07 ` Ansuel Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210502230710.30676-18-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).