From: Jakub Kicinski <kuba@kernel.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, idosch@idosch.org,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH ethtool-next v2 7/7] netlink: stats: add on --all-groups option
Date: Mon, 3 May 2021 08:59:01 -0700 [thread overview]
Message-ID: <20210503085901.63cc248e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210502213640.lqykslgktlvjpaa5@lion.mk-sys.cz>
On Sun, 2 May 2021 23:36:40 +0200 Michal Kubecek wrote:
> > Add a switch for querying all statistic groups available
> > in the kernel.
> >
> > To reject --groups and --all-groups being specified
> > for one request add a concept of "parameter equivalency"
>
> I like the idea but the term "equivalency" may be a bit misleading.
> Maybe "alternatives" would express the relation better.
Thanks for the review! I take it you mean to rename the code as well?
Not just the commit message?
next prev parent reply other threads:[~2021-05-03 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 15:40 [PATCH ethtool-next v2 0/7] ethtool: support FEC and standard stats Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 1/7] update UAPI header copies Jakub Kicinski
2021-05-02 21:16 ` Michal Kubecek
2021-04-22 15:40 ` [PATCH ethtool-next v2 2/7] json: improve array print API Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 3/7] netlink: add FEC support Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 4/7] netlink: fec: support displaying statistics Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 5/7] ethtool: add nlchk for redirecting to netlink Jakub Kicinski
2021-05-02 21:39 ` Michal Kubecek
2021-04-22 15:40 ` [PATCH ethtool-next v2 6/7] netlink: add support for standard stats Jakub Kicinski
2021-04-22 15:40 ` [PATCH ethtool-next v2 7/7] netlink: stats: add on --all-groups option Jakub Kicinski
2021-05-02 21:36 ` Michal Kubecek
2021-05-03 15:59 ` Jakub Kicinski [this message]
2021-05-03 16:11 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503085901.63cc248e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).