From: Jakub Kicinski <kuba@kernel.org>
To: David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PACTH iproute2-next] ip: dynamically size columns when printing stats
Date: Mon, 3 May 2021 12:22:42 -0700 [thread overview]
Message-ID: <20210503122242.6ae77bde@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <be91d0cd-6233-3c8d-e310-a1b7fc842b48@gmail.com>
On Mon, 3 May 2021 11:16:41 -0600 David Ahern wrote:
> On 5/3/21 10:00 AM, Jakub Kicinski wrote:
> > On Mon, 3 May 2021 07:57:39 -0700 Stephen Hemminger wrote:
> >> Maybe good time to refactor the code to make it table driven rather
> >> than individual statistic items.
> >
> > 🤔 should be doable.
> >
> > Can I do it on top or before making the change to the columns?
> >
>
> I think it can be a follow on change. This one is clearly an improvement
> for large numbers.
Fun little discrepancy b/w JSON and plain on what's printed with -s
vs -s -s: JSON output prints rx_over_errors where plain would print
rx_missed_errors. I will change plain to follow JSON, since presumably
we should worry more about breaking machine-readable format.
next prev parent reply other threads:[~2021-05-03 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 3:10 [PACTH iproute2-next] ip: dynamically size columns when printing stats Jakub Kicinski
2021-05-03 14:57 ` Stephen Hemminger
2021-05-03 16:00 ` Jakub Kicinski
2021-05-03 17:16 ` David Ahern
2021-05-03 19:22 ` Jakub Kicinski [this message]
2021-05-04 2:15 ` David Ahern
2021-05-04 16:46 ` Jakub Kicinski
2021-05-09 22:53 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503122242.6ae77bde@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).