From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9878AC433B4 for ; Mon, 3 May 2021 16:11:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AF8A61183 for ; Mon, 3 May 2021 16:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbhECQMK (ORCPT ); Mon, 3 May 2021 12:12:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:42904 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbhECQMK (ORCPT ); Mon, 3 May 2021 12:12:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2CF5EB20F; Mon, 3 May 2021 16:11:16 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id 04992607D5; Mon, 3 May 2021 18:11:16 +0200 (CEST) Date: Mon, 3 May 2021 18:11:15 +0200 From: Michal Kubecek To: Jakub Kicinski Cc: netdev@vger.kernel.org, idosch@idosch.org, Ido Schimmel Subject: Re: [PATCH ethtool-next v2 7/7] netlink: stats: add on --all-groups option Message-ID: <20210503161115.3vjsn5uxm5wuj55k@lion.mk-sys.cz> References: <20210422154050.3339628-1-kuba@kernel.org> <20210422154050.3339628-8-kuba@kernel.org> <20210502213640.lqykslgktlvjpaa5@lion.mk-sys.cz> <20210503085901.63cc248e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210503085901.63cc248e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 03, 2021 at 08:59:01AM -0700, Jakub Kicinski wrote: > On Sun, 2 May 2021 23:36:40 +0200 Michal Kubecek wrote: > > > Add a switch for querying all statistic groups available > > > in the kernel. > > > > > > To reject --groups and --all-groups being specified > > > for one request add a concept of "parameter equivalency" > > > > I like the idea but the term "equivalency" may be a bit misleading. > > Maybe "alternatives" would express the relation better. > > Thanks for the review! I take it you mean to rename the code as well? > Not just the commit message? Yes, if we agree that the term is a bit misleading, I would rather see the struct member renamed. Michal