From: Manivannan Sadhasivam <mani@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Kopp <thomas.kopp@microchip.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] can: mcp251xfd: fix an error pointer dereference in probe
Date: Mon, 3 May 2021 22:17:32 +0530 [thread overview]
Message-ID: <20210503164732.GB3958@thinkpad> (raw)
In-Reply-To: <YJANZf13Qxd5Mhr1@mwanda>
On Mon, May 03, 2021 at 05:49:09PM +0300, Dan Carpenter wrote:
> When we converted this code to use dev_err_probe() we accidentally
> removed a return. It means that if devm_clk_get() it will lead to
> an Oops when we call clk_get_rate() on the next line.
>
> Fixes: cf8ee6de2543 ("can: mcp251xfd: mcp251xfd_probe(): use dev_err_probe() to simplify error handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
> index 970dc570e7a5..f122976e90da 100644
> --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
> +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
> @@ -2885,8 +2885,8 @@ static int mcp251xfd_probe(struct spi_device *spi)
>
> clk = devm_clk_get(&spi->dev, NULL);
> if (IS_ERR(clk))
> - dev_err_probe(&spi->dev, PTR_ERR(clk),
> - "Failed to get Oscillator (clock)!\n");
> + return dev_err_probe(&spi->dev, PTR_ERR(clk),
> + "Failed to get Oscillator (clock)!\n");
> freq = clk_get_rate(clk);
>
> /* Sanity check */
> --
> 2.30.2
>
prev parent reply other threads:[~2021-05-03 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 14:49 [PATCH net] can: mcp251xfd: fix an error pointer dereference in probe Dan Carpenter
2021-05-03 14:53 ` Marc Kleine-Budde
2021-05-03 16:47 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503164732.GB3958@thinkpad \
--to=mani@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=thomas.kopp@microchip.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).