From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C2EC43462 for ; Mon, 3 May 2021 17:00:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09AB461176 for ; Mon, 3 May 2021 17:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbhECRBp (ORCPT ); Mon, 3 May 2021 13:01:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:43308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234069AbhECQ5R (ORCPT ); Mon, 3 May 2021 12:57:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 91E1461176; Mon, 3 May 2021 16:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620060464; bh=GJ7TwwZNdhpalyTS0v9ThEIBUeLJlxiXzIDExLIL4Io=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fP/kEM4vPdbXkP5KGinPqzG+3HwMtnPYhCbeK0uejBILfqskCNQVqMXfND6ZptX0r PY7/l72hEv6AvFotwH1oWthetWLATIXHPeEFl7ejRR/ryhvc7C4NOa8NR0yhK6xoTr llFtXjZCxedI4bBP0SVsHUl1vVAPsklnRFTZz18qTFN3pYnfYwT/lR1xwG7jJCVE0Z MkAuQE61VKXb+3jtEY1/Ma19/MDPjNgKjkSEEoxbGEtoTviLEDtMWiW86sp8RBisZa gtR4sUzOrw6KNDdzRnQusgfYv2rn49Pbgdm6Zd9k3e7voanT3ZCTMegGJOpSmST0XD DD2PKI0g4ZoMg== Date: Mon, 3 May 2021 22:17:32 +0530 From: Manivannan Sadhasivam To: Dan Carpenter Cc: Marc Kleine-Budde , Thomas Kopp , Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski , linux-can@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] can: mcp251xfd: fix an error pointer dereference in probe Message-ID: <20210503164732.GB3958@thinkpad> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 03, 2021 at 05:49:09PM +0300, Dan Carpenter wrote: > When we converted this code to use dev_err_probe() we accidentally > removed a return. It means that if devm_clk_get() it will lead to > an Oops when we call clk_get_rate() on the next line. > > Fixes: cf8ee6de2543 ("can: mcp251xfd: mcp251xfd_probe(): use dev_err_probe() to simplify error handling") > Signed-off-by: Dan Carpenter Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c > index 970dc570e7a5..f122976e90da 100644 > --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c > +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c > @@ -2885,8 +2885,8 @@ static int mcp251xfd_probe(struct spi_device *spi) > > clk = devm_clk_get(&spi->dev, NULL); > if (IS_ERR(clk)) > - dev_err_probe(&spi->dev, PTR_ERR(clk), > - "Failed to get Oscillator (clock)!\n"); > + return dev_err_probe(&spi->dev, PTR_ERR(clk), > + "Failed to get Oscillator (clock)!\n"); > freq = clk_get_rate(clk); > > /* Sanity check */ > -- > 2.30.2 >