Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dt-bindings: net: renesas,etheravb: Fix optional second clock name
@ 2021-05-04  9:03 Geert Uytterhoeven
  2021-05-04 14:05 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-05-04  9:03 UTC (permalink / raw)
  To: Sergei Shtylyov, David S . Miller, Jakub Kicinski, Rob Herring,
	Adam Ford
  Cc: netdev, linux-renesas-soc, devicetree, linux-kernel, Geert Uytterhoeven

If the optional "clock-names" property is present, but the optional TXC
reference clock is not, "make dtbs_check" complains:

    ethernet@e6800000: clock-names: ['fck'] is too short

Fix this by declaring that a single clock name is valid.
While at it, drop the superfluous upper limit on the number of clocks,
as it is implied by the list of descriptions.

Fixes: 6f43735b6da64bd4 ("dt-bindings: net: renesas,etheravb: Add additional clocks")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
index fe72a5598addf89c..005868f703a6e2cd 100644
--- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
@@ -51,12 +51,12 @@ properties:
 
   clocks:
     minItems: 1
-    maxItems: 2
     items:
       - description: AVB functional clock
       - description: Optional TXC reference clock
 
   clock-names:
+    minItems: 1
     items:
       - const: fck
       - const: refclk
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: net: renesas,etheravb: Fix optional second clock name
  2021-05-04  9:03 [PATCH] dt-bindings: net: renesas,etheravb: Fix optional second clock name Geert Uytterhoeven
@ 2021-05-04 14:05 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-05-04 14:05 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: David S . Miller, Adam Ford, Rob Herring, linux-kernel,
	devicetree, linux-renesas-soc, netdev, Sergei Shtylyov,
	Jakub Kicinski

On Tue, 04 May 2021 11:03:00 +0200, Geert Uytterhoeven wrote:
> If the optional "clock-names" property is present, but the optional TXC
> reference clock is not, "make dtbs_check" complains:
> 
>     ethernet@e6800000: clock-names: ['fck'] is too short
> 
> Fix this by declaring that a single clock name is valid.
> While at it, drop the superfluous upper limit on the number of clocks,
> as it is implied by the list of descriptions.
> 
> Fixes: 6f43735b6da64bd4 ("dt-bindings: net: renesas,etheravb: Add additional clocks")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04  9:03 [PATCH] dt-bindings: net: renesas,etheravb: Fix optional second clock name Geert Uytterhoeven
2021-05-04 14:05 ` Rob Herring

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git