From: Vladimir Oltean <olteanv@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Sean Wang" <sean.wang@mediatek.com>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-staging@lists.linux.dev, devicetree@vger.kernel.org,
netdev@vger.kernel.org, "Weijie Gao" <weijie.gao@mediatek.com>,
"Chuanhong Guo" <gch981213@gmail.com>,
"René van Dorst" <opensource@vdorst.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH net-next 1/4] net: phy: add MediaTek PHY driver
Date: Thu, 6 May 2021 14:33:25 +0300 [thread overview]
Message-ID: <20210506113325.b7kwybdgxkoj7rqp@skbuf> (raw)
In-Reply-To: <20210429062130.29403-2-dqfext@gmail.com>
On Thu, Apr 29, 2021 at 02:21:27PM +0800, DENG Qingfang wrote:
> Add support for MediaTek PHYs found in MT7530 and MT7531 switches.
> The initialization procedure is from the vendor driver, but due to lack
> of documentation, the function of some register values remains unknown.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
> RFC v4 -> PATCH v1:
> - No changes.
>
> drivers/net/phy/Kconfig | 5 ++
> drivers/net/phy/Makefile | 1 +
> drivers/net/phy/mediatek.c | 112 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 118 insertions(+)
> create mode 100644 drivers/net/phy/mediatek.c
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 288bf405ebdb..9db39fb443e6 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -207,6 +207,11 @@ config MARVELL_88X2222_PHY
> Support for the Marvell 88X2222 Dual-port Multi-speed Ethernet
> Transceiver.
>
> +config MEDIATEK_PHY
> + tristate "MediaTek PHYs"
> + help
> + Supports the MediaTek switch integrated PHYs.
> +
> config MICREL_PHY
> tristate "Micrel PHYs"
> help
> diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
> index bcda7ed2455d..ab512cb3592b 100644
> --- a/drivers/net/phy/Makefile
> +++ b/drivers/net/phy/Makefile
> @@ -64,6 +64,7 @@ obj-$(CONFIG_LXT_PHY) += lxt.o
> obj-$(CONFIG_MARVELL_10G_PHY) += marvell10g.o
> obj-$(CONFIG_MARVELL_PHY) += marvell.o
> obj-$(CONFIG_MARVELL_88X2222_PHY) += marvell-88x2222.o
> +obj-$(CONFIG_MEDIATEK_PHY) += mediatek.o
> obj-$(CONFIG_MESON_GXL_PHY) += meson-gxl.o
> obj-$(CONFIG_MICREL_KS8995MA) += spi_ks8995.o
> obj-$(CONFIG_MICREL_PHY) += micrel.o
> diff --git a/drivers/net/phy/mediatek.c b/drivers/net/phy/mediatek.c
> new file mode 100644
> index 000000000000..86e6c466b0e9
> --- /dev/null
> +++ b/drivers/net/phy/mediatek.c
> @@ -0,0 +1,112 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +#include <linux/bitfield.h>
> +#include <linux/module.h>
> +#include <linux/phy.h>
> +
> +#define MTK_EXT_PAGE_ACCESS 0x1f
> +#define MTK_PHY_PAGE_STANDARD 0x0000
> +#define MTK_PHY_PAGE_EXTENDED 0x0001
> +#define MTK_PHY_PAGE_EXTENDED_2 0x0002
> +#define MTK_PHY_PAGE_EXTENDED_3 0x0003
> +#define MTK_PHY_PAGE_EXTENDED_2A30 0x2a30
> +#define MTK_PHY_PAGE_EXTENDED_52B5 0x52b5
> +
> +static int mtk_phy_read_page(struct phy_device *phydev)
> +{
> + return __phy_read(phydev, MTK_EXT_PAGE_ACCESS);
> +}
> +
> +static int mtk_phy_write_page(struct phy_device *phydev, int page)
> +{
> + return __phy_write(phydev, MTK_EXT_PAGE_ACCESS, page);
> +}
> +
> +static void mtk_phy_config_init(struct phy_device *phydev)
> +{
> + /* Disable EEE */
> + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0);
Is there any ERR around this (i.e. is the feature universally broken or
just on your setup)? There is a function called of_set_phy_eee_broken,
you can let the PHY core disable EEE advertisement based on device tree.
> +
> + /* Enable HW auto downshift */
> + phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4));
> +
> + /* Increase SlvDPSready time */
> + phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
> + __phy_write(phydev, 0x10, 0xafae);
> + __phy_write(phydev, 0x12, 0x2f);
> + __phy_write(phydev, 0x10, 0x8fae);
> + phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
> +
> + /* Adjust 100_mse_threshold */
> + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x123, 0xffff);
> +
> + /* Disable mcc */
> + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0xa6, 0x300);
> +}
next prev parent reply other threads:[~2021-05-06 11:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 6:21 [PATCH net-next 0/4] MT7530 interrupt support DENG Qingfang
2021-04-29 6:21 ` [PATCH net-next 1/4] net: phy: add MediaTek PHY driver DENG Qingfang
2021-04-29 21:26 ` Andrew Lunn
2021-04-29 23:40 ` Florian Fainelli
2021-05-06 11:33 ` Vladimir Oltean [this message]
2021-04-29 6:21 ` [PATCH net-next 2/4] net: dsa: mt7530: add interrupt support DENG Qingfang
2021-04-29 21:29 ` Andrew Lunn
2021-04-29 23:39 ` Florian Fainelli
2021-05-06 11:42 ` Vladimir Oltean
2021-04-29 6:21 ` [PATCH net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding DENG Qingfang
2021-04-29 21:30 ` Andrew Lunn
2021-04-29 23:31 ` Florian Fainelli
2021-05-03 19:35 ` Rob Herring
2021-04-29 6:21 ` [PATCH net-next 4/4] staging: mt7621-dts: enable MT7530 interrupt controller DENG Qingfang
2021-04-29 21:30 ` Andrew Lunn
2021-04-29 23:31 ` Florian Fainelli
2021-05-06 11:48 ` Vladimir Oltean
2021-04-30 0:08 ` [PATCH net-next 0/4] MT7530 interrupt support David Miller
2021-04-30 2:38 ` DENG Qingfang
2021-04-30 12:24 ` Andrew Lunn
2021-04-30 12:37 ` Aw: " Frank Wunderlich
2021-04-30 12:44 ` Andrew Lunn
2021-04-30 12:56 ` Aw: " Frank Wunderlich
2021-04-30 13:13 ` Andrew Lunn
2021-04-30 14:59 ` Aw: " Frank Wunderlich
2021-04-30 16:34 ` Andrew Lunn
2021-05-05 9:31 ` Landen Chao
2021-05-05 9:43 ` DENG Qingfang
2021-05-06 12:54 ` Landen Chao
2021-05-07 7:55 ` DENG Qingfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506113325.b7kwybdgxkoj7rqp@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=gch981213@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=tglx@linutronix.de \
--cc=vivien.didelot@gmail.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).