From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Willem de Bruijn <willemb@google.com>,
Miaohe Lin <linmiaohe@huawei.com>
Subject: Re: [PATCH net 1/4] net: fix double-free on fraglist GSO skbs
Date: Thu, 6 May 2021 14:17:39 -0700 [thread overview]
Message-ID: <20210506141739.0ab66f99@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <78da518b491d0ad87380786dddf465c98706a865.camel@redhat.com>
On Thu, 06 May 2021 17:55:36 +0200 Paolo Abeni wrote:
> On Thu, 2021-05-06 at 10:32 -0400, Willem de Bruijn wrote:
> > On Thu, May 6, 2021 at 7:07 AM Paolo Abeni <pabeni@redhat.com> wrote:
> > > If we want to be safe about future possible sock_wfree users, I think
> > > the approach here should be different: in skb_segment(), tail-
> > > > destructor is expected to be NULL, while skb_segment_list(), all the
> > > list skbs can be owned by the same socket. Possibly we could open-
> > > code skb_release_head_state(), omitting the skb orphaning part
> > > for sock_wfree() destructor.
> > >
> > > Note that the this is not currently needed - sock_wfree destructor
> > > can't reach there.
> > >
> > > Given all the above, I'm unsure if you are fine with (or at least do
> > > not oppose to) the code proposed in this patch?
> >
> > Yes. Thanks for clarifying, Paolo.
>
> Thank you for reviewing!
>
> @David, @Jakub: I see this series is already archived as "change
> requested", should I repost?
Yes, please. Patch 2 adds two new sparse warnings.
I think you need csum_unfold() to go from __sum16 to __wsum.
next prev parent reply other threads:[~2021-05-06 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 15:35 [PATCH net 0/4] udp: more FRAGLIST fixes Paolo Abeni
2021-05-05 15:35 ` [PATCH net 1/4] net: fix double-free on fraglist GSO skbs Paolo Abeni
2021-05-05 16:13 ` Willem de Bruijn
2021-05-05 17:28 ` Paolo Abeni
2021-05-05 17:30 ` Willem de Bruijn
2021-05-06 11:06 ` Paolo Abeni
2021-05-06 14:32 ` Willem de Bruijn
2021-05-06 15:55 ` Paolo Abeni
2021-05-06 21:17 ` Jakub Kicinski [this message]
2021-05-07 8:46 ` Paolo Abeni
2021-05-10 15:37 ` Paolo Abeni
2021-05-11 9:39 ` Steffen Klassert
2021-05-05 15:35 ` [PATCH net 2/4] udp: fix out-of-bound at segmentation time Paolo Abeni
2021-05-05 15:35 ` [PATCH net 3/4] udp: fix outer header csum for SKB_GSO_FRAGLIST over UDP tunnel Paolo Abeni
2021-05-05 15:35 ` [PATCH net 4/4] selftests: more UDP GRO tests Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506141739.0ab66f99@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linmiaohe@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).