From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CB9C43460 for ; Fri, 7 May 2021 23:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E65B561352 for ; Fri, 7 May 2021 23:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230111AbhEGXfH (ORCPT ); Fri, 7 May 2021 19:35:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbhEGXfG (ORCPT ); Fri, 7 May 2021 19:35:06 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B878EC061574; Fri, 7 May 2021 16:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Obn8yFobEofJRh9FwpjTS8meYjAzVFek9JAqVu5ENuY=; b=nWjrKqf54loxxG+Mt6kn0Tkz4 rUrvforUoKl/gdSsOIAwOmPNPdzZnfbL32KuKpb9v25u8IO/J5sZdtM4pYAjBb9xyGck/DHeHpSRc eRp4Yak4/wqXOgh78wYh3KplwlYsklQk0kXxydnd0VKLN46Ww04SbtS+qhkUA4CavACrZNAkzfsd/ DopeQGXqfMiFI5Sk4cGk4HZaPiB5zLP6H6Lq8c/SFe86/CjTUxg6tRr4+OlUpuWfzWqjMgZHtQ5MV h03UOBpNksCnPSjEHQ8iyzhX7d/6wGFdDK79QcEmvOZApKxEjV54EiSNm3TjNwBJG7He/uVkUZbWq IUksMPjNg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43770) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf9yk-0004yz-Qn; Sat, 08 May 2021 00:33:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lf9yj-00069J-Fg; Sat, 08 May 2021 00:33:53 +0100 Date: Sat, 8 May 2021 00:33:53 +0100 From: Russell King - ARM Linux admin To: Ansuel Smith Cc: Vladimir Oltean , Florian Fainelli , Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v3 19/20] net: dsa: qca8k: pass switch_revision info to phy dev_flags Message-ID: <20210507233353.GE1336@shell.armlinux.org.uk> References: <20210504222915.17206-1-ansuelsmth@gmail.com> <20210504222915.17206-19-ansuelsmth@gmail.com> <20210506112458.yhgbpifebusc2eal@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, May 08, 2021 at 01:26:02AM +0200, Ansuel Smith wrote: > On Thu, May 06, 2021 at 02:24:58PM +0300, Vladimir Oltean wrote: > > On Wed, May 05, 2021 at 12:29:13AM +0200, Ansuel Smith wrote: > > > Define get_phy_flags to pass switch_Revision needed to tweak the > > > internal PHY with debug values based on the revision. > > > > > > Signed-off-by: Ansuel Smith > > > --- > > > drivers/net/dsa/qca8k.c | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > > > index b4cd891ad35d..237e09bb1425 100644 > > > --- a/drivers/net/dsa/qca8k.c > > > +++ b/drivers/net/dsa/qca8k.c > > > @@ -1654,6 +1654,24 @@ qca8k_port_vlan_del(struct dsa_switch *ds, int port, > > > return ret; > > > } > > > > > > +static u32 qca8k_get_phy_flags(struct dsa_switch *ds, int port) > > > +{ > > > + struct qca8k_priv *priv = ds->priv; > > > + > > > + pr_info("revision from phy %d", priv->switch_revision); > > > > Log spam. > > > > > + /* Communicate to the phy internal driver the switch revision. > > > + * Based on the switch revision different values needs to be > > > + * set to the dbg and mmd reg on the phy. > > > + * The first 2 bit are used to communicate the switch revision > > > + * to the phy driver. > > > + */ > > > + if (port > 0 && port < 6) > > > + return priv->switch_revision; > > > + > > > + return 0; > > > +} > > > + > > > static enum dsa_tag_protocol > > > qca8k_get_tag_protocol(struct dsa_switch *ds, int port, > > > enum dsa_tag_protocol mp) > > > @@ -1687,6 +1705,7 @@ static const struct dsa_switch_ops qca8k_switch_ops = { > > > .phylink_mac_config = qca8k_phylink_mac_config, > > > .phylink_mac_link_down = qca8k_phylink_mac_link_down, > > > .phylink_mac_link_up = qca8k_phylink_mac_link_up, > > > + .get_phy_flags = qca8k_get_phy_flags, > > > }; > > > > > > static int qca8k_read_switch_id(struct qca8k_priv *priv) > > > -- > > > 2.30.2 > > > > > > > Florian, I think at one point you said that a correct user of > > phydev->dev_flags should first check the PHY revision and not apply > > dev_flags in blind, since they are namespaced to each PHY driver? > > It sounds a bit circular to pass the PHY revision to the PHY through > > phydev->dev_flags, either that or I'm missing some piece. > > Just to make sure. This is the SWITCH revision not the PHY revision. It > was pointed out in old version that I should get this value from the PHY > regs but they are different values. This is why the dsa driver needs to > use the dev_flags to pass the SWITCH revision to the phy driver. Am I > implementing this in the wrong way and I should declare something to > pass this value in a more standard way? (anyway i'm pushing v4 so i > don't know if we should continue that there) Vladimir is confused - it is not PHY revision at all, but the PHY identifiers. What was actually suggested was checking the PHY identifiers before passing PHY-driver specific flags, so that we didn't end up setting driver private flags that are intending for one driver, but end up actually binding a different driver, and mis-interpreting the flags. This is one of the problems of the current scheme: it's just a meaningless opaque u32 variable with no defined structure to it that the various PHY drivers themselves use in whatever way they see fit. That is only fine to use _if_ you know for certain which driver is going to bind ahead of time. As I mentioned in direct reply to your patch, there was discussions about this back in February, but they seem to have stalled. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!