From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2CEC433B4 for ; Thu, 13 May 2021 13:34:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5ADA5613B6 for ; Thu, 13 May 2021 13:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234050AbhEMNfx (ORCPT ); Thu, 13 May 2021 09:35:53 -0400 Received: from mail.aperture-lab.de ([116.203.183.178]:56756 "EHLO mail.aperture-lab.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233997AbhEMNfj (ORCPT ); Thu, 13 May 2021 09:35:39 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 464743E8F5; Thu, 13 May 2021 15:34:26 +0200 (CEST) Date: Thu, 13 May 2021 15:34:24 +0200 From: Linus =?utf-8?Q?L=C3=BCssing?= To: Nikolay Aleksandrov Cc: netdev@vger.kernel.org, Roopa Prabhu , Jakub Kicinski , "David S . Miller" , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv Message-ID: <20210513133423.GB2222@otheros> References: <20210512231941.19211-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Last-TLS-Session-Version: TLSv1.2 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 13, 2021 at 03:02:13PM +0300, Nikolay Aleksandrov wrote: > Nice work overall, thank you. I hope it was tested well. :) > It'd be great if later you could add some selftests. > > Cheers, > Nik Hi Nikolay, I think I found a way now to better deal with the protocol specific hlist_for_each_entry(), by using hlist_for_each() and a helper function, to reduce the duplicate code with br_{ip4,ip6}_multicast_get_rport_slot() as you suggested (and also removing duplicate code with br_{ip4,ip6}_multicast_mark_router()) and reworked patches 7 and 9 a bit for that... Sorry for the inconvience and my bad timing with your reviews. But thanks a lot for all your valuable feedback! Also netdevbpf patchwork had a few more remarks, they should hopefully be fixed now, too. Regards, Linus