From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A00C433ED for ; Fri, 14 May 2021 22:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 157966140A for ; Fri, 14 May 2021 22:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234115AbhENWxl (ORCPT ); Fri, 14 May 2021 18:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230371AbhENWxl (ORCPT ); Fri, 14 May 2021 18:53:41 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED107C06174A; Fri, 14 May 2021 15:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xgSsfKWkA74e0iXAMwBxkWJB/DtTeegQWgf7EKPF2SU=; b=Sy+SUM4cfMuNPa9aN/X8S7cGM MPQs+haIZnGFUHksu//RCxpMISA9lmq7A6dtz4c9cvKubmw6YAYBS0VHhklpf8KQspJDeVtOcFn5+ xSzSjSTEGdwOoH6iMNnUoZVf9HImUXCd9y612TTQGVfYJDhZRWupnOyt39pNiegoSUUN5TqffaKix S6GsZygOAb6ZQhpLnMAcV3zmvofxdYiNp5nn/LQQgPtNoFcx0ptKR4H1emIZT5iJs12XTmKd27bJ1 fw67LdkX8VdUMk6iQDGS9MPAVSwGt27muDBfStLdxcBC9mE0YqqXKJOxMulelisERs/n/85QSUMNk E7wH92Dtg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43986) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhgfR-0000Wu-Qf; Fri, 14 May 2021 23:52:25 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lhgfR-0004NM-Db; Fri, 14 May 2021 23:52:25 +0100 Date: Fri, 14 May 2021 23:52:25 +0100 From: "Russell King (Oracle)" To: Ansuel Smith Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Rob Herring , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v6 02/25] net: dsa: qca8k: use iopoll macro for qca8k_busy_wait Message-ID: <20210514225225.GI12395@shell.armlinux.org.uk> References: <20210514210015.18142-1-ansuelsmth@gmail.com> <20210514210015.18142-3-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514210015.18142-3-ansuelsmth@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 14, 2021 at 10:59:52PM +0200, Ansuel Smith wrote: > Use iopoll macro instead of while loop. > > Signed-off-by: Ansuel Smith > Reviewed-by: Andrew Lunn This doesn't look quite right to me. > static int > qca8k_busy_wait(struct qca8k_priv *priv, u32 reg, u32 mask) > { > - unsigned long timeout; > - > - timeout = jiffies + msecs_to_jiffies(20); > + u32 val; val is unsigned here. > + /* Check if qca8k_read has failed for a different reason > + * before returning -ETIMEDOUT > + */ > + if (ret < 0 && val < 0) but here you are checking it for a negative number - this will always be false, making the conditional code unreachable. Either the test is wrong, or the type of val is wrong. Please resolve. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!