From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC4EC433B4 for ; Wed, 19 May 2021 13:34:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50CC4611B0 for ; Wed, 19 May 2021 13:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353720AbhESNfx (ORCPT ); Wed, 19 May 2021 09:35:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55958 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241996AbhESNfv (ORCPT ); Wed, 19 May 2021 09:35:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621431271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SdV44jVaacxr1+AFi3mVghLkW/SIKtTOhZzTCyx48gk=; b=NQGETE3/2wXP2azveq6m10ny0eLzaCo1kGEuf7jHzH1UqDq2jLGfjQQJ99YdEDSXWi4Iqy lxxStTTb0OxXzduBj5yd1/KZGZ57580FYHvh2hZa8kluhWUgcKfN4JtRxa0yMFjgeyHnD8 atPGBHsYYNulCtNk6NXhutu/rzJKn2s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-acL1kEQEPtuwU_yk1ipY-Q-1; Wed, 19 May 2021 09:34:27 -0400 X-MC-Unique: acL1kEQEPtuwU_yk1ipY-Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C36A107ACF8; Wed, 19 May 2021 13:34:24 +0000 (UTC) Received: from carbon (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8265D60CCC; Wed, 19 May 2021 13:34:19 +0000 (UTC) Date: Wed, 19 May 2021 15:34:18 +0200 From: Jesper Dangaard Brouer To: Kurt Kanzenbach Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Sven Auhagen , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Ilias Apalodimas , Lorenzo Bianconi , Sebastian Andrzej Siewior , Richard Cochran , Alexander Duyck , Tyler S , Maciej Fijalkowski , brouer@redhat.com Subject: Re: [PATCH net v4] igb: Fix XDP with PTP enabled Message-ID: <20210519153418.00c4cc42@carbon> In-Reply-To: <20210504102827.342f6302@carbon> References: <20210503072800.79936-1-kurt@linutronix.de> <20210504102827.342f6302@carbon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Maintainers, What is the status on this patch? I don't see this fix being applied on git-trees net or net-next. [0] 20210503072800.79936-1-kurt@linutronix.de [1] https://patchwork.kernel.org/project/netdevbpf/patch/20210503072800.79936-1-kurt@linutronix.de/ [2] https://lore.kernel.org/netdev/20210503072800.79936-1-kurt@linutronix.de/ On Tue, 4 May 2021 10:28:27 +0200 Jesper Dangaard Brouer wrote: > On Mon, 3 May 2021 09:28:00 +0200 > Kurt Kanzenbach wrote: > > > When using native XDP with the igb driver, the XDP frame data doesn't point to > > the beginning of the packet. It's off by 16 bytes. Everything works as expected > > with XDP skb mode. > > > > Actually these 16 bytes are used to store the packet timestamps. Therefore, pull > > the timestamp before executing any XDP operations and adjust all other code > > accordingly. The igc driver does it like that as well. > > > > Tested with Intel i210 card and AF_XDP sockets. > > > > Fixes: 9cbc948b5a20 ("igb: add XDP support") > > Signed-off-by: Kurt Kanzenbach > > Thanks for fixing this! > > Acked-by: Jesper Dangaard Brouer > > I expect that we/I will (soon) play with getting this area that is > stored in front of the packet (the XDP data_meta area) described via > BTF. This way both xdp_frame and AF_XDP can get structured access (e.g. > to the PTP timestamp in this case). > > I'll be adding my notes on this project here: > https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/ > > Looking forward to collaborate on this with you :-) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer