From: Christian Brauner <christian.brauner@ubuntu.com>
To: Changbin Du <changbin.du@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jakub Kici nski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Cong Wang <xiyou.wangcong@gmail.com>,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [PATCH v4] net: make get_net_ns return error if NET_NS is disabled
Date: Sat, 12 Jun 2021 16:10:05 +0200 [thread overview]
Message-ID: <20210612141005.igoy2di6xhbkg7cq@wittgenstein> (raw)
In-Reply-To: <20210611142959.92358-1-changbin.du@gmail.com>
On Fri, Jun 11, 2021 at 10:29:59PM +0800, Changbin Du wrote:
> There is a panic in socket ioctl cmd SIOCGSKNS when NET_NS is not enabled.
> The reason is that nsfs tries to access ns->ops but the proc_ns_operations
> is not implemented in this case.
>
> [7.670023] Unable to handle kernel NULL pointer dereference at virtual address 00000010
> [7.670268] pgd = 32b54000
> [7.670544] [00000010] *pgd=00000000
> [7.671861] Internal error: Oops: 5 [#1] SMP ARM
> [7.672315] Modules linked in:
> [7.672918] CPU: 0 PID: 1 Comm: systemd Not tainted 5.13.0-rc3-00375-g6799d4f2da49 #16
> [7.673309] Hardware name: Generic DT based system
> [7.673642] PC is at nsfs_evict+0x24/0x30
> [7.674486] LR is at clear_inode+0x20/0x9c
>
> The same to tun SIOCGSKNS command.
>
> To fix this problem, we make get_net_ns() return -EINVAL when NET_NS is
> disabled. Meanwhile move it to right place net/core/net_namespace.c.
>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> Fixes: c62cce2caee5 ("net: add an ioctl to get a socket network namespace")
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: David Laight <David.Laight@ACULAB.COM>
> Cc: Christian Brauner <christian.brauner@ubuntu.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
Looks good,
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2021-06-12 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 14:29 [PATCH v4] net: make get_net_ns return error if NET_NS is disabled Changbin Du
2021-06-12 14:10 ` Christian Brauner [this message]
2021-06-14 19:12 ` David Miller
2021-06-14 23:35 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612141005.igoy2di6xhbkg7cq@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=David.Laight@ACULAB.COM \
--cc=changbin.du@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).