From: Jakub Kicinski <kuba@kernel.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/tls: don't change cipher type in bidirectional test
Date: Fri, 18 Jun 2021 14:41:49 -0700 [thread overview]
Message-ID: <20210618144149.35192fcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210618204532.257773-1-seth.forshee@canonical.com>
On Fri, 18 Jun 2021 15:45:32 -0500 Seth Forshee wrote:
> The bidirectional test attempts to change the cipher to
> TLS_CIPHER_AES_GCM_128. The test fixture setup will have already set
> the cipher to be tested, and if it was different than the one set by
> the bidir test setsockopt() will fail on account of having different
> ciphers for rx and tx, causing the test to fail.
It's setting it up in the opposite direction, TLS is uni-directional.
I've posted this earlier:
https://patchwork.kernel.org/project/netdevbpf/patch/20210618202504.1435179-2-kuba@kernel.org/
Sorry for not CCing you.
next prev parent reply other threads:[~2021-06-18 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 20:45 [PATCH] selftests/tls: don't change cipher type in bidirectional test Seth Forshee
2021-06-18 21:41 ` Jakub Kicinski [this message]
2021-06-18 22:04 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618144149.35192fcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).