archive mirror
 help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <>
Cc: Oliver Hartkopp <>,
	Marc Kleine-Budde <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,,,
	Thadeu Lima de Souza Cascardo <>,,
	Norbert Slusarek <>
Subject: [PATCH] can: bcm: delay release of struct bcm_op after synchronize_rcu
Date: Sat, 19 Jun 2021 13:18:13 -0300	[thread overview]
Message-ID: <> (raw)

can_rx_register callbacks may be called concurrently to the call to
can_rx_unregister. The callbacks and callback data, though, are protected by
RCU and the struct sock reference count.

So the callback data is really attached to the life of sk, meaning that it
should be released on sk_destruct. However, bcm_remove_op calls tasklet_kill,
and RCU callbacks may be called under RCU softirq, so that cannot be used on
kernels before the introduction of HRTIMER_MODE_SOFT.

However, bcm_rx_handler is called under RCU protection, so after calling
can_rx_unregister, we may call synchronize_rcu in order to wait for any RCU
read-side critical sections to finish. That is, bcm_rx_handler won't be called
anymore for those ops. So, we only free them, after we do that synchronize_rcu.

Reported-by: Norbert Slusarek <>
Signed-off-by: Thadeu Lima de Souza Cascardo <>
 net/can/bcm.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/can/bcm.c b/net/can/bcm.c
index f3e4d9528fa3..c67916020e63 100644
--- a/net/can/bcm.c
+++ b/net/can/bcm.c
@@ -785,6 +785,7 @@ static int bcm_delete_rx_op(struct list_head *ops, struct bcm_msg_head *mh,
 						  bcm_rx_handler, op);
+			synchronize_rcu();
 			return 1; /* done */
@@ -1533,6 +1534,11 @@ static int bcm_release(struct socket *sock)
 					  bcm_rx_handler, op);
+	}
+	synchronize_rcu();
+	list_for_each_entry_safe(op, next, &bo->rx_ops, list) {

             reply	other threads:[~2021-06-19 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 16:18 Thadeu Lima de Souza Cascardo [this message]
2021-06-19 16:25 ` Oliver Hartkopp
2021-06-19 20:12 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] can: bcm: delay release of struct bcm_op after synchronize_rcu' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).