From: Vladimir Oltean <olteanv@gmail.com>
To: Boris Sukholitko <boris.sukholitko@broadcom.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Cong Wang <xiyou.wangcong@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Vadym Kochan <vadym.kochan@plvision.eu>,
Ilya Lifshits <ilya.lifshits@broadcom.com>
Subject: Re: [PATCH net-next] Revert "net/sched: cls_flower: Remove match on n_proto"
Date: Mon, 21 Jun 2021 13:11:14 +0300 [thread overview]
Message-ID: <20210621101114.26hvcfhsbsagkzru@skbuf> (raw)
In-Reply-To: <20210621092429.10043-1-boris.sukholitko@broadcom.com>
On Mon, Jun 21, 2021 at 12:24:29PM +0300, Boris Sukholitko wrote:
> This reverts commit 0dca2c7404a938cb10c85d0515cee40ed5348788.
>
> The commit in question breaks hardware offload of flower filters.
>
> Quoting Vladimir Oltean <olteanv@gmail.com>:
>
> fl_hw_replace_filter() and fl_reoffload() create a struct
> flow_cls_offload with a rule->match.mask member derived from the mask
> of the software classifier: &f->mask->key - that same mask that is used
> for initializing the flow dissector keys, and the one from which Boris
> removed the basic.n_proto member because it was bothering him.
>
> Reported-by: Vadym Kochan <vadym.kochan@plvision.eu>
> Signed-off-by: Boris Sukholitko <boris.sukholitko@broadcom.com>
> ---
Perhaps not the most relevant crop from the quote, but anyway:
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2021-06-21 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 9:24 [PATCH net-next] Revert "net/sched: cls_flower: Remove match on n_proto" Boris Sukholitko
2021-06-21 10:11 ` Vladimir Oltean [this message]
2021-06-21 21:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621101114.26hvcfhsbsagkzru@skbuf \
--to=olteanv@gmail.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=ilya.lifshits@broadcom.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vadym.kochan@plvision.eu \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).