From: kernel test robot <lkp@intel.com>
To: Jussi Maki <joamaki@gmail.com>, bpf@vger.kernel.org
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
daniel@iogearbox.net, j.vosburgh@gmail.com, andy@greyhouse.net,
vfalico@gmail.com, andrii@kernel.org,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
Jussi Maki <joamaki@gmail.com>
Subject: Re: [PATCH bpf-next v3 3/5] net: bonding: Add XDP support to the bonding driver
Date: Tue, 13 Jul 2021 15:14:45 +0800 [thread overview]
Message-ID: <202107131548.CFsq4rn4-lkp@intel.com> (raw)
In-Reply-To: <20210707112551.9782-4-joamaki@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3177 bytes --]
Hi Jussi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jussi-Maki/net-bonding-Refactor-bond_xmit_hash-for-use-with-xdp_buff/20210707-211616
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: m68k-randconfig-s032-20210713 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/127745a2455bc3577cdcafb06381fa4da354f8c2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jussi-Maki/net-bonding-Refactor-bond_xmit_hash-for-use-with-xdp_buff/20210707-211616
git checkout 127745a2455bc3577cdcafb06381fa4da354f8c2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/net/bonding/bond_main.c:2671:26: sparse: sparse: restricted __be16 degrades to integer
drivers/net/bonding/bond_main.c:2677:20: sparse: sparse: restricted __be16 degrades to integer
drivers/net/bonding/bond_main.c:2724:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] vlan_proto @@ got int @@
drivers/net/bonding/bond_main.c:2724:40: sparse: expected restricted __be16 [usertype] vlan_proto
drivers/net/bonding/bond_main.c:2724:40: sparse: got int
>> drivers/net/bonding/bond_main.c:4632:16: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct bond_up_slave *slaves @@ got struct bond_up_slave [noderef] __rcu *usable_slaves @@
drivers/net/bonding/bond_main.c:4632:16: sparse: expected struct bond_up_slave *slaves
drivers/net/bonding/bond_main.c:4632:16: sparse: got struct bond_up_slave [noderef] __rcu *usable_slaves
drivers/net/bonding/bond_main.c:3563:52: sparse: sparse: restricted __be16 degrades to integer
drivers/net/bonding/bond_main.c:3563:52: sparse: sparse: restricted __be16 degrades to integer
vim +4632 drivers/net/bonding/bond_main.c
4623
4624 static struct slave *bond_xdp_xmit_3ad_xor_slave_get(struct bonding *bond,
4625 struct xdp_buff *xdp)
4626 {
4627 struct bond_up_slave *slaves;
4628 unsigned int count;
4629 u32 hash;
4630
4631 hash = bond_xmit_hash_xdp(bond, xdp);
> 4632 slaves = bond->usable_slaves;
4633 count = slaves ? READ_ONCE(slaves->count) : 0;
4634 if (unlikely(!count))
4635 return NULL;
4636
4637 return slaves->arr[hash % count];
4638 }
4639
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22479 bytes --]
next prev parent reply other threads:[~2021-07-13 7:15 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 13:55 [PATCH bpf-next 0/3] XDP bonding support Jussi Maki
2021-06-09 13:55 ` [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver Jussi Maki
2021-06-09 22:29 ` Maciej Fijalkowski
2021-06-09 23:29 ` Jay Vosburgh
2021-06-14 8:02 ` Jussi Maki
2021-06-17 3:40 ` kernel test robot
2021-06-17 6:35 ` kernel test robot
2021-06-22 7:24 ` kernel test robot
2021-06-09 13:55 ` [PATCH bpf-next 2/3] net: bonding: Use per-cpu rr_tx_counter Jussi Maki
2021-06-10 0:04 ` Jay Vosburgh
2021-06-14 7:54 ` Jussi Maki
2021-06-09 13:55 ` [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding Jussi Maki
2021-06-09 22:07 ` Maciej Fijalkowski
2021-06-14 8:08 ` Jussi Maki
2021-06-14 8:48 ` Magnus Karlsson
2021-06-14 12:20 ` Jussi Maki
2021-06-10 17:24 ` [PATCH bpf-next 0/3] XDP bonding support Andrii Nakryiko
2021-06-14 12:25 ` Jussi Maki
2021-06-14 15:37 ` Jay Vosburgh
2021-06-15 5:34 ` Andrii Nakryiko
2021-06-24 9:18 ` [PATCH bpf-next v2 0/4] " joamaki
2021-06-24 9:18 ` [PATCH bpf-next v2 1/4] net: bonding: Refactor bond_xmit_hash for use with xdp_buff joamaki
2021-06-24 9:18 ` [PATCH bpf-next v2 2/4] net: core: Add support for XDP redirection to slave device joamaki
2021-06-24 9:18 ` [PATCH bpf-next v2 3/4] net: bonding: Add XDP support to the bonding driver joamaki
2021-06-24 9:18 ` [PATCH bpf-next v2 4/4] devmap: Exclude XDP broadcast to master device joamaki
2021-07-01 18:12 ` Jay Vosburgh
2021-07-05 11:44 ` Jussi Maki
2021-07-01 18:20 ` [PATCH bpf-next v2 0/4] XDP bonding support Jay Vosburgh
2021-07-05 10:32 ` Jussi Maki
2021-07-07 11:25 ` [PATCH bpf-next v3 0/5] " Jussi Maki
2021-07-07 11:25 ` [PATCH bpf-next v3 1/5] net: bonding: Refactor bond_xmit_hash for use with xdp_buff Jussi Maki
2021-07-07 11:25 ` [PATCH bpf-next v3 2/5] net: core: Add support for XDP redirection to slave device Jussi Maki
2021-07-07 11:25 ` [PATCH bpf-next v3 3/5] net: bonding: Add XDP support to the bonding driver Jussi Maki
2021-07-13 7:14 ` kernel test robot [this message]
2021-07-07 11:25 ` [PATCH bpf-next v3 4/5] devmap: Exclude XDP broadcast to master device Jussi Maki
2021-07-07 11:25 ` [PATCH bpf-next v3 5/5] net: core: Allow netdev_lower_get_next_private_rcu in bh context Jussi Maki
2021-07-28 23:43 ` [PATCH bpf-next v4 0/6] XDP bonding support joamaki
2021-07-28 23:43 ` [PATCH bpf-next v4 1/6] net: bonding: Refactor bond_xmit_hash for use with xdp_buff joamaki
2021-07-28 23:43 ` [PATCH bpf-next v4 2/6] net: core: Add support for XDP redirection to slave device joamaki
2021-07-28 23:43 ` [PATCH bpf-next v4 3/6] net: bonding: Add XDP support to the bonding driver joamaki
2021-07-28 23:43 ` [PATCH bpf-next v4 4/6] devmap: Exclude XDP broadcast to master device joamaki
2021-07-28 23:43 ` [PATCH bpf-next v4 5/6] net: core: Allow netdev_lower_get_next_private_rcu in bh context joamaki
2021-07-28 23:43 ` [PATCH bpf-next v4 6/6] selftests/bpf: Add tests for XDP bonding joamaki
2021-08-03 0:19 ` Andrii Nakryiko
2021-08-03 9:40 ` Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 0/7] XDP bonding support Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 1/7] net: bonding: Refactor bond_xmit_hash for use with xdp_buff Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 2/7] net: core: Add support for XDP redirection to slave device Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 3/7] net: bonding: Add XDP support to the bonding driver Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 4/7] devmap: Exclude XDP broadcast to master device Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 5/7] net: core: Allow netdev_lower_get_next_private_rcu in bh context Jussi Maki
2021-07-30 6:18 ` [PATCH bpf-next v5 6/7] selftests/bpf: Fix xdp_tx.c prog section name Jussi Maki
2021-08-04 23:35 ` Andrii Nakryiko
2021-07-30 6:18 ` [PATCH bpf-next v5 7/7] selftests/bpf: Add tests for XDP bonding Jussi Maki
2021-08-04 23:33 ` Andrii Nakryiko
2021-07-31 5:57 ` [PATCH bpf-next v6 0/7]: XDP bonding support Jussi Maki
2021-07-31 5:57 ` [PATCH bpf-next v6 1/7] net: bonding: Refactor bond_xmit_hash for use with xdp_buff Jussi Maki
2021-08-11 1:52 ` Jonathan Toppins
2021-08-11 8:22 ` Jussi Maki
2021-08-11 14:05 ` Jonathan Toppins
2021-08-16 9:05 ` Jussi Maki
2021-07-31 5:57 ` [PATCH bpf-next v6 2/7] net: core: Add support for XDP redirection to slave device Jussi Maki
2021-07-31 5:57 ` [PATCH bpf-next v6 3/7] net: bonding: Add XDP support to the bonding driver Jussi Maki
2021-07-31 5:57 ` [PATCH bpf-next v6 4/7] devmap: Exclude XDP broadcast to master device Jussi Maki
2021-07-31 5:57 ` [PATCH bpf-next v6 5/7] net: core: Allow netdev_lower_get_next_private_rcu in bh context Jussi Maki
2021-07-31 5:57 ` [PATCH bpf-next v6 6/7] selftests/bpf: Fix xdp_tx.c prog section name Jussi Maki
2021-08-06 22:53 ` Andrii Nakryiko
2021-07-31 5:57 ` [PATCH bpf-next v6 7/7] selftests/bpf: Add tests for XDP bonding Jussi Maki
2021-08-06 22:50 ` Andrii Nakryiko
2021-08-09 14:24 ` Jussi Maki
2021-08-09 21:41 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107131548.CFsq4rn4-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=andy@greyhouse.net \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=j.vosburgh@gmail.com \
--cc=joamaki@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).