From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05BB3C11F66 for ; Tue, 13 Jul 2021 18:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4F4261158 for ; Tue, 13 Jul 2021 18:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234366AbhGMSmy (ORCPT ); Tue, 13 Jul 2021 14:42:54 -0400 Received: from mail.netfilter.org ([217.70.188.207]:38740 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbhGMSmx (ORCPT ); Tue, 13 Jul 2021 14:42:53 -0400 Received: from netfilter.org (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 2DDF062437; Tue, 13 Jul 2021 20:39:45 +0200 (CEST) Date: Tue, 13 Jul 2021 20:40:02 +0200 From: Pablo Neira Ayuso To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ryder.lee@mediatek.com Subject: Re: [RFC 3/7] net: ethernet: mtk_eth_soc: implement flow offloading to WED devices Message-ID: <20210713184002.GA26070@salvia> References: <20210713160745.59707-1-nbd@nbd.name> <20210713160745.59707-4-nbd@nbd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210713160745.59707-4-nbd@nbd.name> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 13, 2021 at 06:07:41PM +0200, Felix Fietkau wrote: [...] > diff --git a/net/core/dev.c b/net/core/dev.c > index c253c2aafe97..7ea6a1db0338 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -885,6 +885,10 @@ int dev_fill_forward_path(const struct net_device *dev, const u8 *daddr, > if (WARN_ON_ONCE(last_dev == ctx.dev)) > return -1; > } > + > + if (!ctx.dev) > + return ret; This is not a safety check, right? After this update ctx.dev might be NULL? > + > path = dev_fwd_path(stack); > if (!path) > return -1; > -- > 2.30.1 >