From: Richard Cochran <richardcochran@gmail.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org,
Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
netdev@vger.kernel.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Ashish K <ashishx.k@intel.com>
Subject: Re: [PATCH net-next v2 1/1] i40e: add support for PTP external synchronization clock
Date: Thu, 22 Jul 2021 04:47:01 -0700 [thread overview]
Message-ID: <20210722114701.GA3439@hoboy.vegasvil.org> (raw)
In-Reply-To: <20210720232348.3087841-1-anthony.l.nguyen@intel.com>
On Tue, Jul 20, 2021 at 04:23:48PM -0700, Tony Nguyen wrote:
> +/**
> + * i40e_set_subsystem_device_id - set subsystem device id
> + * @hw: pointer to the hardware info
> + *
> + * Set PCI subsystem device id either from a pci_dev structure or
> + * a specific FW register.
> + **/
> +static inline void i40e_set_subsystem_device_id(struct i40e_hw *hw)
> +{
> + struct pci_dev *pdev = ((struct i40e_pf *)hw->back)->pdev;
> +
> + hw->subsystem_device_id = pdev->subsystem_device ?
> + pdev->subsystem_device :
> + (ushort)(rd32(hw, I40E_PFPCI_SUBSYSID) & USHRT_MAX);
> +}
> +
> /**
> * i40e_probe - Device initialization routine
> * @pdev: PCI device information struct
> @@ -15262,7 +15281,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> hw->device_id = pdev->device;
> pci_read_config_byte(pdev, PCI_REVISION_ID, &hw->revision_id);
> hw->subsystem_vendor_id = pdev->subsystem_vendor;
> - hw->subsystem_device_id = pdev->subsystem_device;
> + i40e_set_subsystem_device_id(hw);
What does this have to do with $SUBJECT? Nothing, AFAICT.
Thanks,
Richard
next prev parent reply other threads:[~2021-07-22 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 23:23 [PATCH net-next v2 1/1] i40e: add support for PTP external synchronization clock Tony Nguyen
2021-07-21 16:00 ` patchwork-bot+netdevbpf
2021-07-22 11:47 ` Richard Cochran [this message]
2021-07-22 12:54 ` Kwapulinski, Piotr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722114701.GA3439@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ashishx.k@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=piotr.kwapulinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).