From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F3CC4338F for ; Fri, 23 Jul 2021 05:56:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7546160E95 for ; Fri, 23 Jul 2021 05:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233875AbhGWFP6 (ORCPT ); Fri, 23 Jul 2021 01:15:58 -0400 Received: from verein.lst.de ([213.95.11.211]:37050 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbhGWFP5 (ORCPT ); Fri, 23 Jul 2021 01:15:57 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 5BFFE68AFE; Fri, 23 Jul 2021 07:56:27 +0200 (CEST) Date: Fri, 23 Jul 2021 07:56:26 +0200 From: Christoph Hellwig To: Boris Pismenny Cc: dsahern@gmail.com, kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com, smalin@marvell.com, boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, benishay@nvidia.com, ogerlitz@nvidia.com, yorayz@nvidia.com, Boris Pismenny Subject: Re: [PATCH v5 net-next 00/36] nvme-tcp receive and tarnsmit offloads Message-ID: <20210723055626.GA32126@lst.de> References: <20210722110325.371-1-borisp@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722110325.371-1-borisp@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 22, 2021 at 02:02:49PM +0300, Boris Pismenny wrote: > From: Boris Pismenny > > Changes since v4: > ========================================= Explaining what the series does should go before the changelog. > * Add transmit offload patches But to be honest, the previous one was already mostly unreviewable, but this is now far beyond this. Please try to get anything that is generally useful first in smaller series and the come back with a somewhat reviewable series. That also means that at least for the code I care about (nvme) the patches should be grouped together, and actually provide meaningful functionality in each patch. Right now even trying to understand what you add to the nvme code requires me to jump all over a gigantic series.