From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CD1C4338F for ; Fri, 23 Jul 2021 06:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D84960E8B for ; Fri, 23 Jul 2021 06:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbhGWF2r (ORCPT ); Fri, 23 Jul 2021 01:28:47 -0400 Received: from verein.lst.de ([213.95.11.211]:37126 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbhGWF2r (ORCPT ); Fri, 23 Jul 2021 01:28:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CBA9367373; Fri, 23 Jul 2021 08:09:17 +0200 (CEST) Date: Fri, 23 Jul 2021 08:09:17 +0200 From: Christoph Hellwig To: Boris Pismenny Cc: dsahern@gmail.com, kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com, smalin@marvell.com, boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, benishay@nvidia.com, ogerlitz@nvidia.com, yorayz@nvidia.com Subject: Re: [PATCH v5 net-next 23/36] net: Add to ulp_ddp support for fallback flow Message-ID: <20210723060917.GB32369@lst.de> References: <20210722110325.371-1-borisp@nvidia.com> <20210722110325.371-24-borisp@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722110325.371-24-borisp@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 22, 2021 at 02:03:12PM +0300, Boris Pismenny wrote: > /* NIC driver informs the ulp that ddp teardown is done - used for async completions*/ > void (*ddp_teardown_done)(void *ddp_ctx); > + /* NIC request ulp to calculate the ddgst and store it in pdu_info->ddgst */ > + void (*ddp_ddgst_fallback)(struct ulp_ddp_pdu_info *pdu_info); Overly long line. More importantly this whole struct should probably use a kerneldoc comment anyway. > } EXPORT_SYMBOL(ulp_ddp_get_pdu_info); > + if (!pdu_info || !between(seq, pdu_info->start_seq, pdu_info->end_seq - 1)) { More overly lone lines. Please make sure to stick to 80 character lines unless you have a really good to go over that. > + //check if this skb contains ddgst field Plase avoid //-style comments. > + return ulp_ddp_fallback_skb(ctx, skb, sk); > +} EXPORT_SYMBOL(ulp_ddp_validate_xmit_skb); This is not how EXPORT_SYMBOLs are place. Also please export any such deep internal interfaces using EXPORT_SYMBOL_GPL.