From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DEAR_SOMETHING, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62351C4338F for ; Sat, 31 Jul 2021 20:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BC4960EEA for ; Sat, 31 Jul 2021 20:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbhGaUxS (ORCPT ); Sat, 31 Jul 2021 16:53:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24609 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbhGaUxR (ORCPT ); Sat, 31 Jul 2021 16:53:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627764790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NLKh7lcyw6eFd0WRIDfpIJ9gRABGUmoa+QxhxAwdiGg=; b=ZgohvIOia2Oa+tHRnXlbieJtXsiSxu1J6SDePCX76bfx+iSxg71L6V7gAHdxW+7L/Zc9ct sy/K7uq2iKThaaKii92meEYQbOwBwwJfgUjcJU8dOBoBw/TFIpPW3He/u3Hh9W7TV3fCRk HKzJ2GE9kbZg9fAF8oxxCsTKbdU4uW0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-FRZoHgusPiORCsIqVfbDjg-1; Sat, 31 Jul 2021 16:53:08 -0400 X-MC-Unique: FRZoHgusPiORCsIqVfbDjg-1 Received: by mail-ed1-f72.google.com with SMTP id o90-20020a5093e30000b02903bb95130460so6485600eda.0 for ; Sat, 31 Jul 2021 13:53:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NLKh7lcyw6eFd0WRIDfpIJ9gRABGUmoa+QxhxAwdiGg=; b=o+/a7zoOAolS4uBbKNe+MQplrfU4ynCzRvS42eMzhnQmuxlcxkJB0zaMETLn0wph0S WT6+6Iom1z3OA8CFslPkNfHKHF0AmQeNRceHq3HGO6IFHJovlv8TW8fTBA9srJlqSX01 CJatCbTSWkln8tePq9370oq11hboK/HD0wwkhaUd36FPwjGjJGA39ZB4RsRNq+Cow+X7 t2oMAtzAJ4tAbuz5cTWpoiPsJZw3AIpElSzukGN7yJnyYSkf9YLPCqRQBiMwOEUXa9Rd UEHT85/p1zGPvzFPMHmjnvcAoLuilLdHPwfk2EKH9nLgrVpHcKxEPK+iG33UzxTIwCvY ePaQ== X-Gm-Message-State: AOAM533OVkFq42p+Fo2+vW9zxqTN/lMwYwM07hLSCFrZzEmX3Udn/XPA +V+1zuiM9pHlQYELPiTbX9IIUFGskoWom1NO/naAbw+QMVC0jbgcZgAlmExbem2GuGjfKZwpKk4 PYCLozvtjqlWk1SgE X-Received: by 2002:a17:906:4917:: with SMTP id b23mr9018219ejq.468.1627764786573; Sat, 31 Jul 2021 13:53:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcU2Zexs5tYOK4nC9hzFUKxKAPmFdvepLQGj+543l7t1orugKe+WOoOFlvaM/MX7ijRbAekg== X-Received: by 2002:a17:906:4917:: with SMTP id b23mr9018207ejq.468.1627764786399; Sat, 31 Jul 2021 13:53:06 -0700 (PDT) Received: from redhat.com ([2.55.154.10]) by smtp.gmail.com with ESMTPSA id x4sm1984980ejb.106.2021.07.31.13.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jul 2021 13:53:05 -0700 (PDT) Date: Sat, 31 Jul 2021 16:53:01 -0400 From: "Michael S. Tsirkin" To: Ivan Cc: Jason Wang , Willem de Bruijn , "David S. Miller" , Tonghao Zhang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski Subject: Re: PROBLEM: virtio_net LRO kernel panics Message-ID: <20210731165155-mutt-send-email-mst@kernel.org> References: <20210730073029-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 30, 2021 at 12:04:18PM -0500, Ivan wrote: > On Fri, Jul 30, 2021 at 6:42 AM Michael S. Tsirkin wrote: > > > > On Thu, Jul 22, 2021 at 06:27:18PM -0500, Ivan wrote: > > > Dear Sir, > > > > > > I've been plagued with kernel panics recently. The problem is easily > > > reproducible on any virtual machine that uses the virtio-net driver > > > from stock Linux kernel. Simply isuse this command: > > > > > > echo 1 > /proc/sys/net/ipv4/ip_forward > > > ...and the kernel panics. > > > > > > Is there any way we can possibly fix this? > > > > > > kernel: ------------[ cut here ]------------ > > > kernel: netdevice: eth0: failed to disable LRO! > > > kernel: WARNING: CPU: 1 PID: 424 at net/core/dev.c:1768 > > > dev_disable_lro+0x108/0x150 > > > kernel: Modules linked in: nls_iso8859_1 nls_cp437 vfat fat usbhid > > > atkbd libps2 ahci libahci virtio_net ohci_pci net_failover failover > > > i8042 serio lpc_ich mfd_core libata ohci_hcd ehci_pci ehci_hcd usbcore > > > rng_core i2c_piix4 i2c_core virtio_pci usb_common > > > virtio_pci_modern_dev virtio_ring virtio loop unix > > > kernel: CPU: 1 PID: 424 Comm: bash Not tainted 5.13.4-gnu.4-NuMini #1 > > > kernel: Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS > > > VirtualBox 12/01/2006 > > > kernel: RIP: 0010:dev_disable_lro+0x108/0x150 > > > kernel: Code: ae 88 74 14 be 25 00 00 00 48 89 df e8 f1 54 ed ff 48 85 > > > c0 48 0f 44 eb 4c 89 e2 48 89 ee 48 c7 c7 00 c6 ae 88 e8 7a 76 0c 00 > > > <0f> 0b e9 2d ff ff ff 80 3d e8 70 97 00 00 49 c7 c4 73 bb ae 88 75 > > > kernel: RSP: 0018:ffffb596c0237d80 EFLAGS: 00010282 > > > kernel: RAX: 0000000000000000 RBX: ffff9af9c1835000 RCX: ffff9af9fed17538 > > > kernel: RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffff9af9fed17530 > > > kernel: RBP: ffff9af9c1835000 R08: ffffffff88c96ac8 R09: 0000000000004ffb > > > kernel: R10: 00000000fffff000 R11: 3fffffffffffffff R12: ffffffff88ac7c3d > > > kernel: R13: 0000000000000000 R14: ffffffff88cb2748 R15: ffff9af9c12166c8 > > > kernel: FS: 00007fd4911b8740(0000) GS:ffff9af9fed00000(0000) > > > knlGS:0000000000000000 > > > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > kernel: CR2: 0000000000532008 CR3: 000000000115c000 CR4: 00000000000406e0 > > > kernel: Call Trace: > > > kernel: devinet_sysctl_forward+0x1ac/0x1e0 > > > kernel: proc_sys_call_handler+0x127/0x230 > > > kernel: new_sync_write+0x114/0x1a0 > > > kernel: vfs_write+0x18c/0x220 > > > kernel: ksys_write+0x5a/0xd0 > > > kernel: do_syscall_64+0x45/0x80 > > > kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae > > > kernel: RIP: 0033:0x7fd4912b79b3 > > > kernel: Code: 8b 15 b9 74 0d 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb > > > b7 0f 1f 00 64 8b 04 25 18 00 00 00 85 c0 75 14 b8 01 00 00 00 0f 05 > > > <48> 3d 00 f0 ff ff 77 55 c3 0f 1f 40 00 48 83 ec 28 48 89 54 24 18 > > > kernel: RSP: 002b:00007ffe96fdd858 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 > > > kernel: RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007fd4912b79b3 > > > kernel: RDX: 0000000000000002 RSI: 0000000000536810 RDI: 0000000000000001 > > > kernel: RBP: 0000000000536810 R08: 000000000000000a R09: 0000000000000000 > > > kernel: R10: 00007fd49134f040 R11: 0000000000000246 R12: 0000000000000002 > > > kernel: R13: 00007fd4913906c0 R14: 00007fd49138c520 R15: 00007fd49138b920 > > > kernel: ---[ end trace ee7985b10570603d ]--- > > > kernel: ------------[ cut here ]------------ > > > > So the warning is easy to reproduce. > > On qemu/kvm just set ctrl_guest_offloads=off for the device. > > I have no control over the settings of the host. > I have full control over the guest. > > > The panic does not seem to trigger for me and you did not provide > > any data about it. What happens? Does guest just freeze? > > I'm not sure if I am misusing the word "panic". (Appologies, not a programer) > No, the guest does not freeze, just, the moment I issue the command... > echo 1 > /proc/sys/net/ipv4/ip_forward > ... and I see the "--[ cut here ]--" message appear in the syslog. > Shortly thereafter my ssh session to that host dies. So the host or to the guest? -- MST