netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: netdev@vger.kernel.org, johannes@sipsolutions.net,
	richard.laing@alliedtelesis.co.nz
Subject: Re: [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver
Date: Mon, 2 Aug 2021 09:40:54 -0700	[thread overview]
Message-ID: <20210802094054.7bc27154@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1627890663-5851-2-git-send-email-loic.poulain@linaro.org>

On Mon,  2 Aug 2021 09:51:02 +0200 Loic Poulain wrote:
> Add new wwan driver for MBIM over MHI. MBIM is a transport protocol
> for IP packets, allowing packet aggregation and muxing. Initially
> designed for USB bus, it is also exposed through MHI bus for QCOM
> based PCIe wwan modems.
> 
> This driver supports the new wwan rtnetlink interface for multi-link
> management and has been tested with Quectel EM120R-GL M2 module.

Let's make sure it builds cleanly with W=1 C=1 first.

drivers/net/wwan/mhi_wwan_mbim.c:83:23: warning: no previous prototype for ‘mhi_mbim_get_link’ [-Wmissing-prototypes]
   83 | struct mhi_mbim_link *mhi_mbim_get_link(struct mhi_mbim_context *mbim,
      |                       ^~~~~~~~~~~~~~~~~
drivers/net/wwan/mhi_wwan_mbim.c:83:22: warning: symbol 'mhi_mbim_get_link' was not declared. Should it be static?

Also - please start putting someone in the To: header, preferably the
maintainer / mailing list thru which you expect the code to be merged.

  reply	other threads:[~2021-08-02 16:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  7:51 [PATCH net-next RESEND 0/2] net: mhi: move MBIM to WWAN Loic Poulain
2021-08-02  7:51 ` [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver Loic Poulain
2021-08-02 16:40   ` Jakub Kicinski [this message]
2021-08-02 17:22     ` Loic Poulain
2021-08-02  7:51 ` [PATCH net-next RESEND 2/2] net: mhi: Remove MBIM protocol Loic Poulain
2021-08-02 16:40   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802094054.7bc27154@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=richard.laing@alliedtelesis.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).