From: Michael Walle <michael@walle.cc>
To: lescoutinhovr@gmail.com
Cc: netdev@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: net: intel/e1000e/netdev.c __ew32_prepare parameter not used?
Date: Tue, 3 Aug 2021 10:50:32 +0200 [thread overview]
Message-ID: <20210803085032.8834-1-michael@walle.cc> (raw)
In-Reply-To: <CAN6UTaw7Rtoz4q-AsDjKbTm7_sU8BrTAmuMp8-wr6FzaxDMe2Q@mail.gmail.com>
Hi,
> It seems the parameter `*hw` is not used.
> Although I didn't find where `FWSM` is defined.
>
> Should it be removed? Or is the parameter really needed?
>
> static void __ew32_prepare(struct e1000_hw *hw)
> {
> s32 i = E1000_ICH_FWSM_PCIM2PCI_COUNT;
>
> while ((er32(FWSM) & E1000_ICH_FWSM_PCIM2PCI) && --i)
> udelay(50);
> }
If you have a look at the definition of er32() (which is a macro and
is defined in e1000.h, you'll see that the hw parameter is used
there without being a parameter of the macro itself. Thus if you'd
rename the parameter you'd get a build error. Not really the best
code to look at when you want to learn coding, because that's an
example how not to do things, IMHO.
-michael
next prev parent reply other threads:[~2021-08-03 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 14:55 net: intel/e1000e/netdev.c __ew32_prepare parameter not used? Leandro Coutinho
2021-08-03 8:50 ` Michael Walle [this message]
2021-08-03 13:15 ` Leandro Coutinho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803085032.8834-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=lescoutinhovr@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).