From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
To: <yhs@fb.com>
Cc: <andrii@kernel.org>, <ast@kernel.org>, <benh@amazon.com>,
<bpf@vger.kernel.org>, <daniel@iogearbox.net>,
<davem@davemloft.net>, <john.fastabend@gmail.com>, <kafai@fb.com>,
<kpsingh@kernel.org>, <kuba@kernel.org>, <kuni1840@gmail.com>,
<kuniyu@amazon.co.jp>, <netdev@vger.kernel.org>,
<songliubraving@fb.com>
Subject: Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.
Date: Wed, 11 Aug 2021 10:35:57 +0900 [thread overview]
Message-ID: <20210811013557.63288-1-kuniyu@amazon.co.jp> (raw)
In-Reply-To: <6ef818ee-ee75-b2f0-5532-7cc3fa4eb68e@fb.com>
From: Yonghong Song <yhs@fb.com>
Date: Tue, 10 Aug 2021 16:46:49 -0700
> On 8/10/21 2:28 AM, Kuniyuki Iwashima wrote:
> > The iterator can output the same result compared to /proc/net/unix.
> >
> > # cat /sys/fs/bpf/unix
> > Num RefCount Protocol Flags Type St Inode Path
> > ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
>
> There seems a misalignment between header line and data line.
> I know /proc/net/unix having this issue as well. But can we adjust
> spacing in bpf program to make header/data properly aligned?
I just followed /proc/net/unix not to break old parsers :)
I'll align it cleanly in the next spin.
>
> > ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@
> >
> > # cat /proc/net/unix
> > Num RefCount Protocol Flags Type St Inode Path
> > ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
> > ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@
> >
> > Note that this prog requires the patch ([0]) for LLVM code gen. Thanks to
> > Yonghong Song for analysing and fixing.
> >
> > [0] https://reviews.llvm.org/D107483
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
>
> LGTM. Thanks!
>
> Acked-by: Yonghong Song <yhs@fb.com>
Thank you, too!!
prev parent reply other threads:[~2021-08-11 1:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 9:28 [PATCH v4 bpf-next 0/3] BPF iterator for UNIX domain socket Kuniyuki Iwashima
2021-08-10 9:28 ` [PATCH v4 bpf-next 1/3] bpf: af_unix: Implement " Kuniyuki Iwashima
2021-08-10 23:25 ` Yonghong Song
2021-08-10 9:28 ` [PATCH v4 bpf-next 2/3] bpf: Support "%c" in bpf_bprintf_prepare() Kuniyuki Iwashima
2021-08-10 23:32 ` Yonghong Song
2021-08-11 21:15 ` Andrii Nakryiko
2021-08-12 2:15 ` Kuniyuki Iwashima
2021-08-12 4:24 ` Andrii Nakryiko
2021-08-12 5:03 ` Kuniyuki Iwashima
2021-08-10 9:28 ` [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program Kuniyuki Iwashima
2021-08-10 23:46 ` Yonghong Song
2021-08-11 1:35 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811013557.63288-1-kuniyu@amazon.co.jp \
--to=kuniyu@amazon.co.jp \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=benh@amazon.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).