From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D450C4338F for ; Thu, 12 Aug 2021 09:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D372F60EB9 for ; Thu, 12 Aug 2021 09:28:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236263AbhHLJ3U (ORCPT ); Thu, 12 Aug 2021 05:29:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44473 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236246AbhHLJ3S (ORCPT ); Thu, 12 Aug 2021 05:29:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628760532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azALnNzJ2DxInJKcscL1YP4WRO484x/30y4kh0GvdSg=; b=cJwtq2iHKfoOr0IUUnu90NeSbSiO8vSHuW0a10GGniK7FOfn1r2yBrVk0D7QpQfmc+ZS3S 40XOacF0PWTcbpBhxcBNpoIwo0Ojtx2GIU+eQ+w3SZV5nYH6ekqw7PFeWbBQgNw0XWgqFQ BwtGWXTlvFGsHHX977KKjaHz/DpYElo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-luCFBKUvPD6MOHwYnQxGzw-1; Thu, 12 Aug 2021 05:28:51 -0400 X-MC-Unique: luCFBKUvPD6MOHwYnQxGzw-1 Received: by mail-wm1-f71.google.com with SMTP id y186-20020a1c32c30000b02902b5ac887cfcso3129630wmy.2 for ; Thu, 12 Aug 2021 02:28:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=azALnNzJ2DxInJKcscL1YP4WRO484x/30y4kh0GvdSg=; b=Nsv7jOIz1y6s3R/+DdOsW75K2TrRteHt0sefg+T9JXpCXaOcHeH7hwkn6c9uNG7jHH GYH4OqlkBGy33dCfy1K2/Zx+iqX4G1Bb6jbQGDV9ncIJLeKTKH9gCwYd4kOpSggD+f8E /BrSapfqwclKgtZILYRtrQha40fyMrEN1qAICPJfgS6d86bwULTMwKfKbJ7WkdIYQ2Yh DnAPO0J1kE6E+RabSVxTunkv20s0IQTCJUAkfcTfVFi9Iet6K/m096oJm5DlhbHLFUDY hokPS02OzKm9elDwbpdFaAqbZxnbkliT1mk2J7cGjmTqKPgP83PRbeg54dByEpwaIceE P0DA== X-Gm-Message-State: AOAM5300xm681uxAhvQ4ptbxyMZv5vIH19K0c7wQusvnKea2n85FsGZr NOW1CCUnspxnzABG8jDNmjbq9JGV+PrFdq/DpayMrylliEk6fhw/wKfNJ9TL0xkLNYHFvNlyqRv G8TcKfNjp3XKh/21a X-Received: by 2002:a7b:cf12:: with SMTP id l18mr14553351wmg.130.1628760530347; Thu, 12 Aug 2021 02:28:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1l289vOE6o41DRiqCxf3bCTO+hW4WWNdkiSVawC7o2rOn/YBaeOsFkBd9K30ANEwDh/ErtQ== X-Received: by 2002:a7b:cf12:: with SMTP id l18mr14553334wmg.130.1628760530160; Thu, 12 Aug 2021 02:28:50 -0700 (PDT) Received: from pc-23.home (2a01cb058d01b600c841afd12834a14e.ipv6.abo.wanadoo.fr. [2a01:cb05:8d01:b600:c841:afd1:2834:a14e]) by smtp.gmail.com with ESMTPSA id c10sm9589411wml.44.2021.08.12.02.28.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 02:28:49 -0700 (PDT) Date: Thu, 12 Aug 2021 11:28:47 +0200 From: Guillaume Nault To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: James Carlson , Chris Fowler , Jakub Kicinski , Paul Mackerras , "David S. Miller" , "linux-ppp@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ppp: Add rtnl attribute IFLA_PPP_UNIT_ID for specifying ppp unit id Message-ID: <20210812092847.GB3525@pc-23.home> References: <20210807163749.18316-1-pali@kernel.org> <20210809122546.758e41de@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210809193109.mw6ritfdu27uhie7@pali> <20210810153941.GB14279@pc-32.home> <20210810171626.z6bgvizx4eaafrbb@pali> <2f10b64e-ba50-d8a5-c40a-9b9bd4264155@workingcode.com> <20210811173811.GE15488@pc-32.home> <20210811180401.owgmie36ydx62iep@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210811180401.owgmie36ydx62iep@pali> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 11, 2021 at 08:04:01PM +0200, Pali Rohár wrote: > On Wednesday 11 August 2021 19:38:11 Guillaume Nault wrote: > > On Tue, Aug 10, 2021 at 02:11:11PM -0400, James Carlson wrote: > > > On 8/10/21 1:16 PM, Pali Rohár wrote: > > > > On Tuesday 10 August 2021 16:38:32 Chris Fowler wrote: > > > > > Isn't the UNIT ID the interface number? As in 'unit 100' will give me ppp100? > > > > > > > > If you do not specify pppd 'ifname' argument then pppd argument 'unit 100' > > > > will cause that interface name would be ppp100. > > > > > > > > But you are free to rename interface to any string which you like, even > > > > to "ppp99". > > > > > > > > But this ppp unit id is not interface number. Interface number is > > > > another number which has nothing with ppp unit id and is assigned to > > > > every network interface (even loopback). You can see them as the first > > > > number in 'ip -o l' output. Or you can retrieve it via if_nametoindex() > > > > function in C. > > > > > > Correct; completely unrelated to the notion of "interface index." > > > > > > > ... So if people are really using pppd's 'unit' argument then I think it > > > > really make sense to support it also in new rtnl interface. > > > > > > The pppd source base is old. It dates to the mid-80's. So it predates not > > > just rename-able interfaces in Linux but Linux itself. > > > > > > I recall supported platforms in the past (BSD-derived) that didn't support > > > allowing the user to specify the unit number. In general, on those > > > platforms, the option was accepted and just ignored, and there were either > > > release notes or man page updates (on that platform) that indicated that > > > "unit N" wouldn't work there. > > > > > > Are there users on Linux who make use of the "unit" option and who would > > > mourn its loss? Nobody really knows. It's an ancient feature that was > > > originally intended to deal with systems that couldn't rename interfaces > > > (where one had to make sure that the actual interface selected matched up > > > with pre-configured filtering rules or static routes or the like), and to > > > make life nice for administrators (e.g., making sure that serial port 1 maps > > > to ppp1, port 2 is ppp2, and so on). > > > > > > I would think and hope most users reach for the more-flexible "ifname" > > > option first, but I certainly can't guarantee it. It could be buried in a > > > script somewhere or (god forbid) some kind of GUI or "usability" tool. > > > > > > If I were back at Sun, I'd probably call it suitable only for a "Major" > > > release, as it removes a publicly documented feature. But I don't know what > > > the considerations are here. Maybe it's just a "don't really care." > > > > I'm pretty sure someone, somewhere, would hate us if we broke the > > "unit" option. The old PPP ioctl API has been there for so long, > > there certainly remains tons of old tools, scripts and config files > > that "just work" without anybody left to debug or upgrade them. > > > > We can't just say, "starting from kernel x.y.z the unit option is a > > noop, use ifname instead" as affected people surely won't get the > > message (and there are other tools beyond pppd that may use this > > kernel API). > > > > But for the netlink API, we don't have to repeat the same mistake. > > ifname is not atomic (first it creates ppp interface and later it is > renamed) and have issues. Due to bug described here: > https://lore.kernel.org/netdev/20210807160050.17687-1-pali@kernel.org/ > you may get your kernel into state in which it is not possible to create > a new ppp interface. And this issue does not happen when using "unit" > argument. This is specific to the ioctl api. Netlink doesn't have this problem. > To fix above issue it is needed to migrate pppd from ioctl API to rtnl. It would have helped a lot if you had explained that before. > But this would be possible only after rtnl API starts providing all > features, including specifying custom "unit" argument... You can already simulate the "unit" option by setting the interface name as "ppp${unit}" and retrieving the kernel assigned id with ioctl(PPPIOCGUNIT). What's wrong with that? > I hit above problem, so now I'm migrating all pppd setups from "ifname" > to "unit" option. Why did you write 3125f26c51482 ("ppp: Fix generating ppp unit id when ifname is not specified") then?