From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, arnd@kernel.org,
rdunlap@infradead.org, richardcochran@gmail.com,
kernel-team@fb.com
Subject: [PATCH net-next] ptp: ocp: Simplify Kconfig.
Date: Wed, 25 Aug 2021 14:17:33 -0700 [thread overview]
Message-ID: <20210825211733.264844-1-jonathan.lemon@gmail.com> (raw)
Remove the 'imply' statements, these apparently are not doing
what I expected. Platform modules which are used by the driver
still need to be enabled in the overall config for them to be
used, but there isn't a hard dependency on them.
Use 'depend' for selectable modules which provide functions
used directly by the driver.
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
drivers/ptp/Kconfig | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 32660dc11354..f02bedf41264 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP
tristate "OpenCompute TimeCard as PTP clock"
depends on PTP_1588_CLOCK
depends on HAS_IOMEM && PCI
- depends on SPI && I2C && MTD
+ depends on I2C && MTD
+ depends on SERIAL_8250
depends on !S390
- imply SPI_MEM
- imply SPI_XILINX
- imply MTD_SPI_NOR
- imply I2C_XILINX
- select SERIAL_8250
select NET_DEVLINK
-
- default n
help
This driver adds support for an OpenCompute time card.
--
2.31.1
next reply other threads:[~2021-08-25 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 21:17 Jonathan Lemon [this message]
2021-08-25 21:32 ` [PATCH net-next] ptp: ocp: Simplify Kconfig Arnd Bergmann
2021-08-25 23:22 ` Randy Dunlap
2021-08-26 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825211733.264844-1-jonathan.lemon@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).