From: Shawn Guo <shawn.guo@linaro.org>
To: "David S . Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>, Alex Elder <elder@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Steev Klimaszewski <steev@kali.org>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipa: Declare IPA firmware with MODULE_FIRMWARE()
Date: Sun, 26 Sep 2021 21:46:29 +0800 [thread overview]
Message-ID: <20210926134628.GC9901@dragon> (raw)
In-Reply-To: <20210926065529.25956-1-shawn.guo@linaro.org>
On Sun, Sep 26, 2021 at 02:55:29PM +0800, Shawn Guo wrote:
> Declare IPA firmware with MODULE_FIRMWARE(), so that initramfs tools can
> build the firmware into initramfs image or warn on missing of the
> firmware.
>
> W: Possible missing firmware /lib/firmware/ipa_fws.mdt for module ipa
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/net/ipa/ipa_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index cdfa98a76e1f..264bebc78d1e 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -545,6 +545,8 @@ static int ipa_firmware_load(struct device *dev)
> return ret;
> }
>
> +MODULE_FIRMWARE(IPA_FW_PATH_DEFAULT);
> +
Just reminded by Steev, .mdt file conventionally means we are using
split firmware. Building only .mdt file into initramfs is not
sufficient. So please disregard the patch.
Shawn
> static const struct of_device_id ipa_match[] = {
> {
> .compatible = "qcom,msm8998-ipa",
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-26 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 6:55 [PATCH] net: ipa: Declare IPA firmware with MODULE_FIRMWARE() Shawn Guo
2021-09-26 13:46 ` Shawn Guo [this message]
2021-09-27 16:07 ` Alex Elder
2021-09-27 19:35 ` Bjorn Andersson
2021-09-27 20:30 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926134628.GC9901@dragon \
--to=shawn.guo@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).