* [PATCH net] net: sun: SUNVNET_COMMON should depend on INET
@ 2021-09-27 21:48 Randy Dunlap
2021-09-28 12:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-09-27 21:48 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, David S. Miller, Jakub Kicinski, Aaron Young,
Rashmi Narasimhan
When CONFIG_INET is not set, there are failing references to IPv4
functions, so make this driver depend on INET.
Fixes these build errors:
sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_start_xmit_common':
sunvnet_common.c:(.text+0x1a68): undefined reference to `__icmp_send'
sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_poll_common':
sunvnet_common.c:(.text+0x358c): undefined reference to `ip_send_check'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Aaron Young <aaron.young@oracle.com>
Cc: Rashmi Narasimhan <rashmi.narasimhan@oracle.com>
---
Fixes: prior to 31762eaa0d08 ("ldmvsw: Split sunvnet driver into common code")
[I don't have enough git fu to go back beyond this.]
drivers/net/ethernet/sun/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210927.orig/drivers/net/ethernet/sun/Kconfig
+++ linux-next-20210927/drivers/net/ethernet/sun/Kconfig
@@ -73,6 +73,7 @@ config CASSINI
config SUNVNET_COMMON
tristate "Common routines to support Sun Virtual Networking"
depends on SUN_LDOMS
+ depends on INET
default m
config SUNVNET
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: sun: SUNVNET_COMMON should depend on INET
2021-09-27 21:48 [PATCH net] net: sun: SUNVNET_COMMON should depend on INET Randy Dunlap
@ 2021-09-28 12:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-28 12:30 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, davem, kuba, aaron.young, rashmi.narasimhan
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 27 Sep 2021 14:48:23 -0700 you wrote:
> When CONFIG_INET is not set, there are failing references to IPv4
> functions, so make this driver depend on INET.
>
> Fixes these build errors:
>
> sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_start_xmit_common':
> sunvnet_common.c:(.text+0x1a68): undefined reference to `__icmp_send'
> sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_poll_common':
> sunvnet_common.c:(.text+0x358c): undefined reference to `ip_send_check'
>
> [...]
Here is the summary with links:
- [net] net: sun: SUNVNET_COMMON should depend on INET
https://git.kernel.org/netdev/net/c/103bde372f08
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-28 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 21:48 [PATCH net] net: sun: SUNVNET_COMMON should depend on INET Randy Dunlap
2021-09-28 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).