From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA03C433FE for ; Tue, 28 Sep 2021 19:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 129C760F70 for ; Tue, 28 Sep 2021 19:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242533AbhI1Thd (ORCPT ); Tue, 28 Sep 2021 15:37:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242208AbhI1Thc (ORCPT ); Tue, 28 Sep 2021 15:37:32 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88E7FC061746 for ; Tue, 28 Sep 2021 12:35:52 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id h20so161184ilj.13 for ; Tue, 28 Sep 2021 12:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=64evIw52oRekIZbHwSiCOQxkuAatfjf85RCST3duN+k=; b=Y+whdzRKhZBi4F0e10aKGWY8V/H37d7/fT7EfJLwEzHf9sW/3ImWPZ9ET2U5Weu4yz ZBjRIgLcc3KjeErqmbig8bPdI+Ka8EUE0FIf5dIotawpBRnC5dom3MQafQisZ8LWVawZ r1pRp649QhA/oJDCUS6senPdUWmeY4p6YtiBUjiG6faSu5HSv5lEtbfP7y0ezWGarR4D pC1C6h2vjPZw+Rer1rFu40SivFJbautH9NtQFhC6bCu4Cmm1NNk6ZDeWvKI3J5H/YtB0 q0/KXjB+kwRbKGl91HsUrqE0Z03rLt11AcxhXGBqB4TNHeHroEl+vdN1zscWzQQApUAZ M1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=64evIw52oRekIZbHwSiCOQxkuAatfjf85RCST3duN+k=; b=eqIHvsghosFsqFC2Ssrgaeqj+MaqOUgFPyZy4T82euP0uue/ow5QRIioN7i1ijt6Xn LFgRmjYFxf/wuOyZ3kN6qlZfnHh+gTXgVSHdt0sDc35WsUto5ktvSfBdEyd00Q565A/i v5PPKBH2EYWrVamNupsC8yLcXsowLE0eXxDEmm2iT6m/kuhb+G6Xvw9SL2wsYoQSYwEK lr4LXoRmbsyhMiKksabPM0XCPon8QuaYPYZxm8LKCSV4O5xQASFdS2c6CJ4sCNwVjPD7 HgrAvLi+lsBEVc9VNZH2791+AjsoZUc0CDudrpgASwrhli2oN2Gdv3KlgkhDeSaMc9ap md5g== X-Gm-Message-State: AOAM5320KM1iw+XmTjATS5ME0CwbCkE8zvZInEyeQPdaYsi1f8oMTMnS lv2VZmzWVyWisapkpXGeM3D/Pw== X-Google-Smtp-Source: ABdhPJzFSVZGvIenvKrDxicIDxRtjRj8KENPEhcmGHIrbBWFLg+wtwG6D65MA29+I55UEiSKkXhAsQ== X-Received: by 2002:a05:6e02:1d1c:: with SMTP id i28mr5559430ila.33.1632857751863; Tue, 28 Sep 2021 12:35:51 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id d6sm11787173ile.51.2021.09.28.12.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 12:35:51 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mVItK-007GOs-GL; Tue, 28 Sep 2021 16:35:50 -0300 Date: Tue, 28 Sep 2021 16:35:50 -0300 From: Jason Gunthorpe To: Alex Williamson Cc: Leon Romanovsky , Doug Ledford , Yishai Hadas , Bjorn Helgaas , "David S. Miller" , Jakub Kicinski , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Saeed Mahameed , Cornelia Huck Subject: Re: [PATCH mlx5-next 2/7] vfio: Add an API to check migration state transition validity Message-ID: <20210928193550.GR3544071@ziepe.ca> References: <20210927164648.1e2d49ac.alex.williamson@redhat.com> <20210927231239.GE3544071@ziepe.ca> <20210928131958.61b3abec.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928131958.61b3abec.alex.williamson@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 28, 2021 at 01:19:58PM -0600, Alex Williamson wrote: > In defining the device state, we tried to steer away from defining it > in terms of the QEMU migration API, but rather as a set of controls > that could be used to support that API to leave us some degree of > independence that QEMU implementation might evolve. That is certainly a different perspective, it would have been better to not express this idea as a FSM in that case... So each state in mlx5vf_pci_set_device_state() should call the correct combination of (un)freeze, (un)quiesce and so on so each state reflects a defined operation of the device? Jason